Skip to content

Add tests for DCS Serializing System Types #21982

@shmao

Description

@shmao

#21433 made changes to many System types and changed they way they're serialized. We'd like to check whether we have tests covering DCS serializing those types. If not, we should add new tests. Here's the list of the types.

dotnet/corefx#20247 added tests for BinaryFormatter serializing the types.

  • System.Boolean
  • System.Byte
  • System.Char
  • System.Collections.Generic.LongEnumEqualityComparer`1[[System.Runtime.Serialization.Formatters.Tests.UInt64Enum]]
  • System.Collections.Generic.EnumEqualityComparer`1[[System.Runtime.Serialization.Formatters.Tests.UInt32Enum]]
  • System.Collections.Generic.SByteEnumEqualityComparer`1[[System.Runtime.Serialization.Formatters.Tests.SByteEnum]]
  • System.Collections.Generic.ShortEnumEqualityComparer`1[[System.Runtime.Serialization.Formatters.Tests.Int16Enum]]
  • System.Collections.Generic.SortedList`2[[System.Int32],[System.Runtime.Serialization.Formatters.Tests.Point]]
  • System.Collections.ObjectModel.ObservableCollection`1[[System.Int32]] // The implementations between core and netfx are completely different. I don't think serialization works here without a custom serialization routine
  • System.Collections.ObjectModel.ReadOnlyDictionary`2[[System.Int32],[System.String]]
  • System.Collections.ObjectModel.ReadOnlyObservableCollection`1[[System.Int32]]
  • System.Collections.Specialized.ListDictionary
  • System.Collections.Specialized.StringCollection
  • System.ComponentModel.BindingList`1[[System.Runtime.Serialization.Formatters.Tests.Point]]
  • System.Data.SqlTypes.SqlBoolean
  • System.Data.SqlTypes.SqlByte
  • System.Data.SqlTypes.SqlDateTime
  • System.Data.SqlTypes.SqlDouble
  • System.Data.SqlTypes.SqlInt16
  • System.Data.SqlTypes.SqlInt32
  • System.Data.SqlTypes.SqlInt64
  • System.Data.SqlTypes.SqlString
  • System.Double
  • System.Drawing.Point
  • System.Drawing.PointF
  • System.Drawing.Rectangle
  • System.Drawing.RectangleF
  • System.Drawing.Size
  • System.Drawing.SizeF
  • System.Globalization.CompareInfo
  • System.Globalization.SortVersion
  • System.Int16
  • System.Int32
  • System.Int64
  • System.Lazy`1[[System.Int32]]
  • System.Net.Cookie
  • System.Net.CookieCollection // I expect issues here as netfx and core are using different types in serialized fields
  • System.Net.CookieContainer
  • System.SByte
  • System.Single
  • System.UInt16
  • System.UInt32
  • System.UInt64

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions