Skip to content

[ci-scan-feedback] Prevent shared-Helix-log catch-all KBE signatures #133010

Closed

Description

@github-actions

Triggering signals

Rubric finding: KBE #131449's array-form ErrorMessage paired Running test: profiler/gc/nongcheap/nongcheap.cmd (announcement line, present in the profiler suite's single shared Helix console log for every test) with Profiler tests are expected to contain the text 'PROFILER TEST PASSES' (a shared-harness error any profiler test can print). Both lines coexist in the same console log, so the signature matched whenever any profiler/** test failed — a catch-all.

Proposed edits

  • .github/workflows/shared/create-kbe.instructions.md (array-form "Rules" list, ~L445) — new rule: do not pair a per-run announcement line with a non-test-specific error line when a leg runs many tests through one shared Helix console log; anchor every element to the failing test's own output, or set ExcludeConsoleLog: true. Ties directly to noahfalk's console-log-matching feedback.
  • .github/workflows/shared/create-kbe.instructions.md ("Bad vs good signatures" table, ~L556) — new Bad/Good row using the [ci-scan] Test failure: profiler/gc/nongcheap/nongcheap.cmd fails with missing 'PROFILER TEST PASSES' #131449 signature as the concrete example.

Expected behavior change

The next scanner run will not emit array-form KBEs whose elements individually match a shared multi-test Helix console log. Signatures that can only be anchored to suite-wide output will either be tightened to the failing test's own lines or set ExcludeConsoleLog: true, avoiding the profiler-style catch-all KBE that buckets unrelated failures.

Note

This PR body was generated by the ci-failure-scan-feedback agentic workflow (AI/Copilot-generated).

Generated by CI Outer-Loop Failure Scanner — Feedback · opus48 · 259.5 AIC · ⌖ 25.4 AIC · ⊞ 20.6K · ◷


Note

This was originally intended as a pull request, but the git push operation failed.

Original error: The process '/usr/bin/git' failed with exit code 1

Workflow Run: View run details and download bundle artifact

The bundle file is available in the agent artifact in the workflow run linked above.

To create a pull request with the changes:

# Download the artifact from the workflow run
gh run download 33510401456 -n agent -D /tmp/agent-33510401456

# Fetch the bundle into a temporary ref, then update the local branch
git fetch /tmp/agent-33510401456/aw-ci-scan-feedback-kbe-shared-helix-log-catchall.bundle refs/heads/ci-scan-feedback/kbe-shared-helix-log-catchall:refs/bundles/create-pr-ci-scan-feedback-kbe-shared-helix-log-catchall-77d6bd95fa74a85b-75f93697
git update-ref refs/heads/ci-scan-feedback/kbe-shared-helix-log-catchall-77d6bd95fa74a85b refs/bundles/create-pr-ci-scan-feedback-kbe-shared-helix-log-catchall-77d6bd95fa74a85b-75f93697
git checkout ci-scan-feedback/kbe-shared-helix-log-catchall-77d6bd95fa74a85b
# Ensure the working tree matches the updated branch
git reset --hard
# Remove the temporary bundle ref
git update-ref -d refs/bundles/create-pr-ci-scan-feedback-kbe-shared-helix-log-catchall-77d6bd95fa74a85b-75f93697

# Push the branch to origin
git push origin ci-scan-feedback/kbe-shared-helix-log-catchall-77d6bd95fa74a85b

# Create the pull request
gh pr create --title '[ci-scan-feedback] Prevent shared-Helix-log catch-all KBE signatures' --base main --head ci-scan-feedback/kbe-shared-helix-log-catchall-77d6bd95fa74a85b --repo dotnet/runtime

Activity

  1. dotnet-policy-service commented on Sep 1, 2026

    @dotnet-policy-service
    Contributor

    Tagging subscribers to this area: @dotnet/runtime-infrastructure
    See info in area-owners.md if you want to be subscribed.

  2. locked and limited conversation to collaborators on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions