-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
api-approvedAPI was approved in API review, it can be implementedAPI was approved in API review, it can be implementedarea-System.Net.Quic
Milestone
Description
Background and motivation
System.Net.Quic is still in Preview, before we un-preview it, we'd like to change this method to an async one.
https://learn.microsoft.com/en-us/dotnet/api/system.net.quic.quicstream.completewrites?view=net-8.0
API Proposal
namespace System.Net.Quic;
// Existing class.
public class QuicStream : Stream
{
- void CompleteWrites();
+ ValueTask CompleteWritesAsync();
}API Usage
await using var quicStream = await connection.OpenStreamAsync(...);
// Use the stream...
await quicStream.CompleteWritesAsync();Alternative Designs
Keeping it not-async and use existing Task WritesClosed property.
Risks
No response
Metadata
Metadata
Assignees
Labels
api-approvedAPI was approved in API review, it can be implementedAPI was approved in API review, it can be implementedarea-System.Net.Quic