Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f860bce
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b3a9b0b
Choose a head ref
  • 7 commits
  • 52 files changed
  • 8 contributors

Commits on Sep 14, 2021

  1. [release/6.0] [tvOS] Be less eager in creating the non-existent speci… 

    …al folders (#59024)

Co-authored-by: Filip Navara <[email protected]>
    @github-actions @filipnavara
    github-actions[bot] and filipnavara authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    56c8a9c View commit details
    Browse the repository at this point in the history

  2. [release/6.0] [wasm][debugger] Fix pause on exception behavior (#58895) 

    Co-authored-by: Ankit Jain <[email protected]>
Co-authored-by: Thays <[email protected]>
    @github-actions @radical @thaystg
    3 people authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    819bc3a View commit details
    Browse the repository at this point in the history

  3. [wasm] Fix circular dependency in WasmAppBuilder (#58905) 

    Fixes #58816

Co-authored-by: Ankit Jain <[email protected]>
    @github-actions @radical
    github-actions[bot] and radical authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    830003d View commit details
    Browse the repository at this point in the history

  4. [release/6.0] Change PKCS12 password to assist with credscan (#59080) 

    * Change PKCS12 password to assist with credscan

* Use placeholder for password

Co-authored-by: Kevin Jones <[email protected]>
    @github-actions @vcsjones
    github-actions[bot] and vcsjones authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    fefe82f View commit details
    Browse the repository at this point in the history

  5. [release/6.0] Support JsonExtensionData in STJ source-gen (#59047) 

    * Support JsonExtensionData in STJ source-gen

* Address review feedback

Co-authored-by: Layomi Akinrinade <[email protected]>
    @github-actions @layomia
    github-actions[bot] and layomia authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    db4c0c2 View commit details
    Browse the repository at this point in the history

  6. Fix sample profiler resolution on Windows. (#59056) 

    If sample profiler was initially created before sampling has been
enabled, happens when setting up sessions during startup,
sample_profiler_load_dependecies won't get called, meaning we won't
setup timeBeginPeriod/timeEndPeriod on Windows, and won't adjust
default scheduling resolution to 1ms staying on default 16ms.

There is a ref count check in current sample_profiler_enable checking
if we should call sample_profiler_load_dependecies (_ref_count == 0),
but in case where we can't start profiling _can_start_sampling == false,
we won't call sample_profiler_enable but always increase _ref_count
that in turn will prevent calls to sample_profiler_load_dependecies when
enabling sample profiler and that in turn won't call timeBeginPeriod
staying on default scheduling resolution.

Fix is to always call sample_profiler_load_dependecies making sure we
will setup needed dependencies when _ref_count == 0.

Co-authored-by: lateralusX <[email protected]>
    @github-actions @lateralusX
    github-actions[bot] and lateralusX authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    bf2a7d0 View commit details
    Browse the repository at this point in the history

  7. [release/6.0] Remove benign assert (#59044) 

    * Remove benign assert

It is perfectly possible for us to replace a promoted struct by its only
field where that field is marked do-not-enregister. Since this path does
handle the proper retyping when normalization is required this assertion
is benign.

Fix #58972

* Fix test

Co-authored-by: Jakob Botsch Nielsen <[email protected]>
    @github-actions @jakobbotsch
    github-actions[bot] and jakobbotsch authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    b3a9b0b View commit details
    Browse the repository at this point in the history
Loading