Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf20e76
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1e96637
Choose a head ref
  • 6 commits
  • 28 files changed
  • 6 contributors

Commits on Aug 31, 2021

  1. Add s390x support in a few places in eng/native build scripts (#58366) 

    * Make isMSBuildOnNETCoreSupported return true on s390x
  (fixes generating version headers)

* Add s390x platform-specific library name in find_unwind_libs
  (enables linking against system-provided libunwind)

Co-authored-by: Ulrich Weigand <[email protected]>
    @github-actions @uweigand
    github-actions[bot] and uweigand authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    5a17bd8 View commit details
    Browse the repository at this point in the history

  2. [release/6.0] [Libraries][Android] Fix alignment for padding System.D… 

    …ecimal (#58380)

Fixes #49872

There is a difference in the current alignment of a decimal type on Android x86 (32bit) MONO_ABI_ALIGNOF (gpointer) which evaluates to 4 bytes and whats expected, which is 8 bytes. The behavior of MONO_ABI_ALIGNOF (gpointer) seems correct as gpointer is void* and 32-bit aligned pointers on a 32-bit platform makes sense. Instead, it's suspected that using MONO_ABI_ALIGNOF (gpointer) as the alignment is not correct for Android x86 if we are expecting an align of 8 bytes.

Attempting to remove the entire special casing for System Decimal in marshal.c didn't seem to work as noted in #49872 (comment)

This PR will adhere to the alignment value of 4 for Android x86, remove the special casing for System.Decimal because CoreCLR had removed their special casing, and modifies the expected values in the tests. https://github.com/dotnet/corefx/pull/30690/files?file-filters%5B%5D=.cs#r199212623 makes me suspect these tests have yet to be modified to fully accomodate Linux platforms.
    @github-actions
    github-actions[bot] authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    114aa9a View commit details
    Browse the repository at this point in the history

  3. Use OutputRid in test projects (#58340) 

    Co-authored-by: Adeel <[email protected]>
    @github-actions @am11
    github-actions[bot] and am11 authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    9f6ad57 View commit details
    Browse the repository at this point in the history

  4. [release/6.0] Enable win registry install location for all architectu… 

    …res (#57851)

* Multi-arch support for win registry install locations

* Change get_dotnet_self_registered_config_location signature

* Link advapi32.lib on win-arm

* PR Feedback

* Indent

* Update get_dotnet_self_registered_config_location()

Co-authored-by: Mateo Torres Ruiz <[email protected]>
    @github-actions
    github-actions[bot] and Mateo Torres Ruiz authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    08b249b View commit details
    Browse the repository at this point in the history

  5. [release/6.0] [wasm] Require workloads if using `@(NativeFileReferenc… 

    …e)` (#58290)

* [wasm] Require workloads, if a project is using native references

Currently, if the `wasm-tools` workload is not installed, and a project
uses AOT, then the build fails with an error saying that the workload
is needed.

But if the project is using native references, but not AOT, then the
build does not fail. Instead, the `@(NativeFileReference)` just gets
ignored. Even though the wasm workload is needed to relink dotnet.wasm
with the native libraries.

Implementation:

- `$(RunAOTCompilation)` is a property, so it can be checked, and
  wasm workload imports can be enabled.
- But `@(NativeFileReference)` is an item, and that gets evaluated in
  the second phase, so we can't use that to affect the imports.
  - Instead, we emit a warning from a target run before Build, if the
    project has any native references, but the workload isn't enabled.

- Users can explicitly enable the workload by setting
  `$(WasmBuildNative)==true`.

* Bump sdk for workload testing to 6.0.100-rc.2.21425.12

* Fix path to workload.stamp file

Co-authored-by: Ankit Jain <[email protected]>
    @github-actions @radical
    github-actions[bot] and radical authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    e8aab6a View commit details
    Browse the repository at this point in the history

  6. [release/6.0] Fix fgValueNumberArrIndexVal for wide reads (#58427) 

    * fix fgValueNumberArrIndexVal for wide reads

* Update test

* Fix regressions

* Update valuenum.cpp

Co-authored-by: EgorBo <[email protected]>
    @github-actions @EgorBo
    github-actions[bot] and EgorBo authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    1e96637 View commit details
    Browse the repository at this point in the history
Loading