Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c0662e8
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0ea8653
Choose a head ref
  • 9 commits
  • 18 files changed
  • 15 contributors

Commits on Aug 11, 2021

  1. Make sure rid specific libs projs get packaged (#57193) 

    * Make sure rid specific libs projs get packaged

RID specific runtime.*.runtime.native.System.IO.Ports projects weren't
packaged because the GeneratePackageOnBuild property wasn't set to true
for them. The property was only true during an allconfigurations build.
As these projects are only built outside of an allconfigurations build,
the GeneratePackageOnBuild property needs to account for such as well.

Also updating the NoTargets Sdk to clean the rid specific package up.

Moving the GeneratePackageOnBuild logic into a props file and set it to
false during servicing (or runtimelab) so that devs can set the property
during servicing directly in the project file if a project should be
packaged.

* Remove the GeneratePackage property

That property was intended to enabled incremental servicing but with
now using the NuGet Pack task we can just make use of the publicl
available GeneratePackageOnBuild property.

* Fix IsPackable setting
    @ViktorHofer
    ViktorHofer authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    85441ce View commit details
    Browse the repository at this point in the history

  2. Improve docs for BinaryData.ToString() (#56325) 

    * Improve docs for BinaryData.ToString()

* Apply suggestions from code review

Co-authored-by: Jeremy Barton <[email protected]>
    @JoshLove-msft @bartonjs
    JoshLove-msft and bartonjs authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    a4f1b6e View commit details
    Browse the repository at this point in the history

  3. [MonoAOTCompiler] accept more than one AotProfilePath (#57111) 

    * [MonoAOTCompiler] accept more than one AotProfilePath

Fixes part of: #56989

The Android workload needs to be able to pass in multiple AOT profiles
to the `<MonoAOTCompiler/>` MSBuild task. We plan on shipping a
default profile in the Android workload, as well as the MAUI workload.
.NET MAUI would have two profiles when using profiled AOT.

Adding `profile-only`, and then multiple `profile` arguments is
currently working in legacy Xamarin.Android:

https://github.com/xamarin/xamarin-android/blob/77895e2a03ed91fdf3729cde54501f91e7d1a36f/src/Xamarin.Android.Build.Tasks/Tasks/GetAotArguments.cs#L256-L260

Either a single property or item group can be passed in for
`AotProfilePath` now. I avoided changing the name, as it looks like it
might be used by wasm.

* Update src/tasks/AotCompilerTask/MonoAOTCompiler.cs

Co-authored-by: Ankit Jain <[email protected]>

Co-authored-by: Ankit Jain <[email protected]>
    @jonathanpeppers @radical
    jonathanpeppers and radical authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    d359e49 View commit details
    Browse the repository at this point in the history

  4. Improve set_position to reuse buffer. (#54991) 

    Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Adam Sitnik <[email protected]>
    @lateapexearlyspeed @jeffhandley @adamsitnik
    3 people authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    ca33c4d View commit details
    Browse the repository at this point in the history

  5. Clean up rd.xml now that DCS has been annotated (#57013) 

    * Clean up rd.xml now that DCS has been annotated

* Adding annotation to keep KeyValue.GetKeyValuePair method

* Use GetMemberWithSameMetadataDefinitionAs instead

* fix typo in the type being kept

* Save constructor metadata as a workaround as opposed to using DynamicDependency
    @joperezr
    joperezr authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    ffa6aae View commit details
    Browse the repository at this point in the history

  6. [Mono] Update instructions for running runtime tests on Android (#57166) 

    * Update instructions for running runtime tests on Android

* Update docs/workflow/testing/mono/testing.md

Co-authored-by: Juan Hoyos <[email protected]>

Co-authored-by: Juan Hoyos <[email protected]>
    @fanyang-mono @hoyosjs
    fanyang-mono and hoyosjs authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    e0ba450 View commit details
    Browse the repository at this point in the history

  7. Fix RuntimeTypeHandle.IsComObject check for __ComObject type (#57171)

    @elinor-fung
    elinor-fung authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    f9bcaa3 View commit details
    Browse the repository at this point in the history

  8. fix issue where HTTP/1.1 connections were not being created asynchron… 

    …ously (#56966)

* fix issue where HTTP/1.1 connections were not being created asynchronously

Co-authored-by: Geoffrey Kizer <[email protected]>
    @geoffkizer
    geoffkizer and Geoffrey Kizer authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    ace0f64 View commit details
    Browse the repository at this point in the history

  9. disable TestConvertFromIntegral on arm with stress. (#57194)

    Sergey Andreenko authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    0ea8653 View commit details
    Browse the repository at this point in the history
Loading