Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a442971
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ab98c9b
Choose a head ref
  • 15 commits
  • 48 files changed
  • 13 contributors

Commits on May 9, 2023

  1. Disable foreground-shutdown test on Windows (#85936) 

    This test has failed across many configurations, but apparently only
on Windows. Tracked by #84006,
#83658.
    @BruceForstall
    BruceForstall authored May 9, 2023
    Configuration menu
    Copy the full SHA
    eaa7ae1 View commit details
    Browse the repository at this point in the history

  2. Do not generate PerfMap entries for methods we didn't compile (#85958) 

    * Do not generate PerfMap entries for methods we didn't compile

dotnet/installer#16318 is currently blocked due to crossgen2 crash. While Jan (dotnet/installer#16318 (comment)) is totally right that the command line to crossgen2 is garbage, we should try not to crash. Based on the stack we already emitted the PE and PDB. The crash seems to be caused by attempting to include methods that didn't successfully compile in the perfmap (`EnumerateCompilerMethods` has an `IsEmpty` check whereas walking all nodes looking for `MethodWithGCInfo` doesn't check that).

```
Internal.TypeSystem.TypeSystemException+TypeLoadException: Failed to load type 'System.Security.Policy.EvidenceBase' from assembly 'System.Security.AccessControl, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.ThrowHelper.ThrowTypeLoadException(ExceptionStringID, String, String) + 0x39 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.ResolutionFailure.Throw() + 0x99 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaModule.GetObject(EntityHandle, NotFoundBehavior) + 0x8f [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaModule.GetType(EntityHandle) + 0x2c [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaType.InitializeBaseType() + 0x81 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaType.ComputeTypeFlags(TypeFlags) + 0x48 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.TypeDesc.InitializeTypeFlags(TypeFlags) + 0x1e [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.TypeNameFormatter.AppendName(StringBuilder, TypeDesc) + 0x2d [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.TypeString.AppendName(StringBuilder, ArrayType) + 0x1b [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.TypeNameFormatter.FormatName(TypeDesc) + 0x54 [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.OutputInfoBuilder.FormatMethodName(MethodDesc, TypeNameFormatter) + 0x174 [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.OutputInfoBuilder.<EnumerateMethods>d__16.MoveNext() + 0x15f [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.Diagnostics.PerfMapWriter.Write(String, Int32, IEnumerable`1, IEnumerable`1, TargetDetails) + 0x13b [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.SymbolFileBuilder.SavePerfMap(String, Int32, String) + 0x1ba [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.DependencyAnalysis.ReadyToRunObjectWriter.EmitPortableExecutable() + 0xa59 [/__w/1/s/src/redist/redist.csproj]
```

This is all based on the stack trace. I didn't validate this fixes the issue (or that it compiles at all) but the fix seems legit to me.

My local workflows are affected by the installer repo break because the runtime repo had a breaking change in CoreLib that is not compatible with existing installer builds. Nobody seems to be doing anything with the failing integration PR, so this is my attempt...
    @MichalStrehovsky
    MichalStrehovsky authored May 9, 2023
    Configuration menu
    Copy the full SHA
    5b90c47 View commit details
    Browse the repository at this point in the history

  3. Add Base64.IsValid and allow Base64.DecodeXx methods to skip whitespa… 

    …ce (#85938)

* Allow Base64Decoder to ignore space chars, add IsValid methods and tests

* Some cleanup of Base64.IsValid changes

This includes making FromBase64Transform significantly faster via SearchValues.

* Address PR feedback and some more cleanup

---------

Co-authored-by: Heath Baron-Morgan <[email protected]>
    @stephentoub @heathbm
    stephentoub and heathbm authored May 9, 2023
    Configuration menu
    Copy the full SHA
    b2d730c View commit details
    Browse the repository at this point in the history

  4. Attempt to bypass emscripten's generated wrappers for cwraps (#85919) 

    Bypass emscripten's generated js wrappers when invoking cwraps, this may improve cross-language inlining
Fix signature for a cwrap that was missing an arg
    @kg
    kg authored May 9, 2023
    Configuration menu
    Copy the full SHA
    f576c78 View commit details
    Browse the repository at this point in the history

  5. [RISC-V] Fixed errors in jit and unwinding (#85900) 

    * [JIT] Fix some errors in JIT

* Fix errors in unwinding

* [JIT] Pass float value with int arg reg

* [JIT] Fix register overwriting in RSVD

* [JIT] jit-format

* Fix an error

* [JIT] Add LOONGARCH64
    @clamp03
    clamp03 authored May 9, 2023
    Configuration menu
    Copy the full SHA
    f1030ed View commit details
    Browse the repository at this point in the history

  6. amend the multiply's overflow check and delete some unused codes. (#8… 

    …5959)
    @shushanhf
    shushanhf authored May 9, 2023
    Configuration menu
    Copy the full SHA
    4677b0d View commit details
    Browse the repository at this point in the history

  7. Fix comment for File.Exists (#85648)

    @SiqiLu
    SiqiLu authored May 9, 2023
    Configuration menu
    Copy the full SHA
    8c96a18 View commit details
    Browse the repository at this point in the history

  8. Fold "FrozenObjectHandle(REF) + CNS" to a byref constant (#85888)

    @EgorBo
    EgorBo authored May 9, 2023
    Configuration menu
    Copy the full SHA
    e338820 View commit details
    Browse the repository at this point in the history

  9. Delete gtNewBlkOpNode and lvSimdBaseJitType (#85848) 

    * Delete "gtNewBlkOpNode"

Note: neither "initobj" nor "cpobj" can be preceded by "volatile.".

Delete the self-assignment handling

Block morphing will fold it to a NOP anyway.

I do not see the referenced liveness bug still being present.
It seems to have been a remnant of COPYBLK/COPYOBJ days.

Move the SIMD logic to gtNewAssignNode

Delete "gtNewBlkOpNode"

* Delete lvSimdBaseJitType
    @SingleAccretion
    SingleAccretion authored May 9, 2023
    Configuration menu
    Copy the full SHA
    b212d5c View commit details
    Browse the repository at this point in the history

  10. Fix ReadOnlySpanGetReferenceAndReadInteger on BigEndian (#85969)

    @EgorBo
    EgorBo authored May 9, 2023
    Configuration menu
    Copy the full SHA
    dd3a027 View commit details
    Browse the repository at this point in the history

  11. Improve IndexOfAnyValues for needles with 0 (#84184)

    @MihaZupan
    MihaZupan authored May 9, 2023
    Configuration menu
    Copy the full SHA
    1b56e96 View commit details
    Browse the repository at this point in the history

  12. Stop special casing reflected-on internals (#85963) 

    * Stop special casing reflected-on internals

Concept of reflection blocked internals was deleted in #85810. This is no longer needed.

* Can no longer access ResourceSet outside corelib
    @MichalStrehovsky
    MichalStrehovsky authored May 9, 2023
    Configuration menu
    Copy the full SHA
    eea36fc View commit details
    Browse the repository at this point in the history

  13. [PERF] Fix Linux Musl Alpine Core Root build (#85946) 

    * Add crossbuild for coreroot building in perf-job.yml
    @LoopedBard3
    LoopedBard3 authored May 9, 2023
    Configuration menu
    Copy the full SHA
    e241509 View commit details
    Browse the repository at this point in the history

  14. Unroll StringBuilder.Append for const string (#85894) 

    Co-authored-by: EgorBo <[email protected]>
    @yesmey @EgorBo
    yesmey and EgorBo authored May 9, 2023
    Configuration menu
    Copy the full SHA
    58a1365 View commit details
    Browse the repository at this point in the history

  15. Disable IUnknownTest under GCStress (#85937) 

    Tracking: #85234
    @BruceForstall
    BruceForstall authored May 9, 2023
    Configuration menu
    Copy the full SHA
    ab98c9b View commit details
    Browse the repository at this point in the history
Loading