Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8148c0c
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fedf1bf
Choose a head ref
  • 12 commits
  • 85 files changed
  • 16 contributors

Commits on Aug 27, 2021

  1. Update dependencies from https://github.com/dotnet/runtime-assets bui…

    …ld 20210825.1 (#58178)
    
    Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
     From Version 6.0.0-beta.21423.1 -> To Version 6.0.0-beta.21425.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    efe56d6 View commit details
    Browse the repository at this point in the history
  2. [release/6.0] Prevent AV in processinfo2 while suspended on Mono. (#5…

    …8158)
    
    #55379 only fixed CoreCLR. This commit makes similar fix in Mono as well, making sure
    src/tests/tracing/eventpipe/diagnosticport runtime test pass on Mono.
    
    Co-authored-by: lateralusX <[email protected]>
    Co-authored-by: Martin Costello <[email protected]>
    3 people authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    824368b View commit details
    Browse the repository at this point in the history
  3. Fix frequent FuncEval abort upon hitting a breakpoint in an ASP.NET C…

    …ore web app (#58218)
    
    - `AssemblySpecBindingCache` uses a cooperative-GC-mode data structure for the cache and operates on the cache from inside a lock taken in preemptive-GC-mode
    - So when the cache is being used, cooperative-GC-mode is entered while holding the lock, which can in turn suspend for the debugger. Then a FuncEval that also happens to operate on the cache would deadlock on acquiring the lock and would have to be aborted.
    - This seems to be happening very frequently when hitting an early breakpoint in a default new ASP.NET Core web app in .NET 6 when hot reload is enabled
    - Fixed by using the same solution that was used for the slot backpatching lock. When cooperative-GC-mode would be entered inside the lock, a different lock holder based on `CrstAndForbidSuspendForDebuggerHolder` is used, which prevents the thread from suspending for the debugger while the lock is held. The thread would instead suspend for the debugger after leaving the forbid region after releasing the lock.
    
    Co-authored-by: Koundinya Veluri <[email protected]>
    github-actions[bot] and Koundinya Veluri authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    bb952db View commit details
    Browse the repository at this point in the history
  4. Handle shadowed property names in DiagnosticsSourceEventSource (#58212)

    Co-authored-by: John Salem <[email protected]>
    github-actions[bot] and John Salem authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    e1b407b View commit details
    Browse the repository at this point in the history
  5. Implement Environment.GetEnvironmentVariables for Apple platforms usi…

    …ng official API (#58161) (#58254)
    
    Move environment handling from Mono runtime to System.Native
    
    Fixes #58156
    
    Co-authored-by: Filip Navara <[email protected]>
    Co-authored-by: Adeel Mujahid <[email protected]>
    3 people authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    4cf2af2 View commit details
    Browse the repository at this point in the history
  6. [release/6.0] [mono] Use string.Empty for empty string custom arg val…

    …ues (#58113)
    
    Co-authored-by: Ulrich Weigand <[email protected]>
    Co-authored-by: Aleksey Kliger <[email protected]>
    3 people authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a021027 View commit details
    Browse the repository at this point in the history
  7. [release/6.0] Fix memory leak in enqueue/dequeue of EventPipe callbac…

    …k data. (#58244)
    
    * Fix memory leak in enqueue/dequeue of EventPipe callback data.
    
    #56104 made sure provider
    callback data gets its own copy of filter data. This created a couple
    of memory leaks when queue/dequeue the callback data since callback data
    was not correctly freed in these scenarios leading to leaks of the copied
    filter data.
    
    Was detected running the manual EventPipe native unit tests on Windows
    using its build in use of _CrtMemCheckpoint (only available in debug
    builds) automatically detecting memory leaks.
    
    Fix makes sure callback data is moved into queue on enqueue and moved
    out in dequeue and that caller of dequeue make sure to
    free returned callback data using ep_provider_callback_data_fini
    when done using it. Doing a move instead of copy will also reduce
    the number of allocations when enqueue/dequeue callback data in
    provider callback queue.
    
    * Fix build error.
    
    Co-authored-by: lateralusX <[email protected]>
    github-actions[bot] and lateralusX authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    59f5157 View commit details
    Browse the repository at this point in the history
  8. [mono] Fix regression introduced by PR 55726 (#58255)

    * Fix endless recursion in AssemblyBuilder.GetCustomAttributesData()
      and ModuleBuilder.GetCustomAttributesData()
    
    * Re-enable test cases that now pass on Mono
    
    Co-authored-by: Ulrich Weigand <[email protected]>
    github-actions[bot] and uweigand authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    30a3aa2 View commit details
    Browse the repository at this point in the history
  9. [release/6.0] Fix VN incorrect optimizations with a new JitEEInterfac…

    …e function. (#58005)
    
    * Add/return tests.
    
    * improve the test naming.
    
    * Add a new JitEE method.
    
    with a naive implementation so far.
    
    * Handle generically dissimilar type concerns as well as handle derived type case in the managed compiler
    
    * Fix the field and Unsafe issues.
    
    * fix some failures.
    
    It appeared that we have many trees where we generate unique VN for rhs and don't inform `fgValueNumberBlockAssignment` about it.
    For example, for
    ```
    N005 ( 10,  8) [000033] -A--G---R---              *  ASG       struct (copy)
    N004 (  3,  2) [000031] D------N----              +--*  LCL_VAR   struct<eightByteStruct, 8> V01 loc1         d:2
    N003 (  6,  5) [000030] n---G-------              \--*  IND       struct
    N002 (  3,  3) [000043] ------------                 \--*  ADDR      byref
    N001 (  3,  2) [000044] -------N----                    \--*  LCL_VAR   struct<largeStruct, 32> V00 loc0         u:6 (last use)
    ```
    we will generate unique rhs but then `fgValueNumberBlockAssignment` will still try to work it as with a non-unique one.
    
    * Fix an oooold bug in VN.
    
    For a tree like:
    ```
    N005 ( 11, 10) [001400] -A------R----             *  ASG       long
    N004 (  6,  5) [001401] *------N-----             +--*  IND       long
    N003 (  3,  3) [001402] -------------             |  \--*  ADDR      byref  Zero Fseq[_00]
    N002 (  3,  2) [001403] U------N-----             |     \--*  LCL_VAR   struct<System.Runtime.Intrinsics.Vector128`1[Byte], 16> V45 tmp38        ud:3->4
    N001 (  1,  1) [001404] -------------             \--*  LCL_VAR   long   V69 tmp62        u:2 (last use)
    ```
    SSA was working correctly and printing that `001403` is using SSA-3 and defining SSA-4. However, this code, for some reason, was writing result as a define for SSA-3.
    
    * Add new test cases and a fix for them.
    
    * correct a test copy paste
    
    * response review.
    
    Co-authored-by: Sergey <[email protected]>
    Co-authored-by: David Wrighton <[email protected]>
    3 people authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    e209402 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e98e0ec View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Configuration menu
    Copy the full SHA
    6289d9e View commit details
    Browse the repository at this point in the history
  2. [release/6.0] [mono] Support RuntimeType.MakeGenericType with non-Run…

    …timeType elements (#58275)
    
    Co-authored-by: Ulrich Weigand <[email protected]>
    github-actions[bot] and uweigand authored Aug 28, 2021
    Configuration menu
    Copy the full SHA
    fedf1bf View commit details
    Browse the repository at this point in the history
Loading