-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Comparing changes
Open a pull request
base repository: dotnet/runtime
base: 71fe9fb
head repository: dotnet/runtime
compare: f860bce
- 10 commits
- 60 files changed
- 13 contributors
Commits on Sep 13, 2021
-
Fix SIMD temp register interference (#58990)
On Windows/x86, if a call returns a SIMD8 in two registers (eax, edx), and needs to be assembled and stored into a single SIMD register, AND we don't have the SSE41 ABI available (because the hardware doesn't support it, or we specifically disable it), then we need a temporary register. In the failure case, the target register and temporary register were the same, and then interfered with each other. The fix is to force the temporary register to be different from the target register. Fixes #58899 Co-authored-by: Bruce Forstall <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d6a35f3 - Browse repository at this point
Copy the full SHA d6a35f3View commit details -
[release/6.0] Skip test suites crashing on CI for iOS/tvOS/MacCatalys…
…t and test fixes for Android (#58841) Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0 Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally. This PR looks to reduce the failures on CI by skipping the problematic suites Skips test suites logged in #53624 ActiveIssues #58440 #58418 #58367 #58584 Co-authored-by: Mitchell Hwang <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: Jo Shields <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3e3fd87 - Browse repository at this point
Copy the full SHA 3e3fd87View commit details -
[release/6.0] [tasks] [net472] Add ProjectReferences to JsonToItemsTa…
…skFactory (#58917) * [tasks] [net472] Add ProjectReferences to JsonToItemsTaskFactory Reference the same versions of System.Threding.Tasks.Extensions and System.Text.Json that MSBuild in Visual Studio 2022 uses. Fixes build errors on maui-ios (and possibly blazorwasm) targets on Windows like: ``` System.MissingMethodException: Method not found: 'System.Threading.Tasks.ValueTask`1<!!0> System.Text.Json.JsonSerializer.DeserializeAsync(System.IO.Stream, System.Text.Json.JsonSerializerOptions, System.Threading.CancellationToken)'. at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.<GetJsonAsync>d__24.MoveNext() at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.GetJsonAsync(String jsonFilePath, FileStream file) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.TryGetJson(String jsonFilePath, JsonModelRoot& json) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.Execute() at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() ``` from `C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.MonoTargets.Sdk\6.0.0-rc.1.21451.13\Sdk\RuntimeComponentManifest.targets` * assembly version is 4.2.0.1, but nuget version is 4.5.4, apparently Co-authored-by: Aleksey Kliger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9a90d3b - Browse repository at this point
Copy the full SHA 9a90d3bView commit details -
Address Windows recommendations for Link APIs (#58592) (#58926)
* NT prefix shall not be treated as a relative path * Remove file-folder-match validation * Use SubstituteName instead of PrintName since the latter is just for display and can be misleading * Fix MS.IO.Redist * Fix whitespace in Strings.resx * Address suggestions
Configuration menu - View commit details
-
Copy full SHA for 188bfd8 - Browse repository at this point
Copy the full SHA 188bfd8View commit details -
[release/6.0] [mini] Use alloca for runtime_invoke retval buffer (#59006
) * [mini] Use alloca for runtime_invoke retval buffer Fixes #58957 Related to #58215 which was attempting to fix #58190 * Set initial return buffer size to TARGET_SIZEOF_VOID_P In the common case we use the return buffer just to hold a pointer to the return value Co-authored-by: Aleksey Kliger <[email protected]> Co-authored-by: Aleksey Kliger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8fe648d - Browse repository at this point
Copy the full SHA 8fe648dView commit details -
Deadlock during rundown using interpreter. (#59023)
Identified deadlock between finalizer thread and rundown enumerating all interpreter method. Since rundown will query for method name in callback when iterating interpreter methods, interp_jit_info_foreach, that might lead to additional loader activity. The hash map in interpreter keeping the methods is locked with default JIT memory manager, but since the callback might end up in mono_class_create_from_typedef that will take loader lock, we get the following lock order on that code path, memory manager->loader lock. Finalizer thread invokes OnThreadExiting using interpreter and that might end up with a reverse lock order, loader lock->memory manager on that code path, so these two have a potential to deadlock. This is not a problem under JIT or AOT since the JIT hash table is lock free therefore not causing any deadlocks due to lock order between memory manager and loader lock. Could be fixed by changing into a lock free hash table in interpreters for interp_code_hash might be to risky at this point. A more safe fix is to take a copy of the pointers while holding lock and then iterate using local copy (simple array of pointers). Since this method is only called during rundown, only when using interpreter, and only include the pointers (InterpMethod *) we use with the callback, it will have some temporary memory impact (allocating an array of pointers), but will mitigate the deadlock since we can safely call iterator callback without holding the lock. It will also improve interpreter performance in situations where we run session rundown, since lock will be held a much shorter amount of time. Co-authored-by: lateralusX <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b70244 - Browse repository at this point
Copy the full SHA 8b70244View commit details -
[release/6.0] Throw on unsupported types in src gen (#58983)
* Throw on unsupported types in src gen * Misc non-functional changes and feedback * Fix typo * Change disallowed terminology to unsupported Co-authored-by: Steve Harter <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 83d5f57 - Browse repository at this point
Copy the full SHA 83d5f57View commit details -
[release/6.0] [wasm][debugger] Clear cache after don't stop in a cond…
…itional breakpoint (#58910) Backport of #58908 to release/6.0 Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1390250?src=WorkItemMention&src-action=artifact_link
Configuration menu - View commit details
-
Copy full SHA for 74d62c2 - Browse repository at this point
Copy the full SHA 74d62c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e5a932 - Browse repository at this point
Copy the full SHA 9e5a932View commit details
Commits on Sep 14, 2021
-
[release/6.0] Set generic type arguments nullability for value types (#…
…58390) * Set generic type arguments nullability for value types * Skip test on mono * Apply commment * Separate var name parts with _ * Reflection nullability API: improve test coverage, fix bug found (#58479) * Add/remove some tests, fix generics indexing bug Co-authored-by: Buyaa Namnan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f860bce - Browse repository at this point
Copy the full SHA f860bceView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 71fe9fb...f860bce