Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 59d9749a22
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 85e8f688ff
Choose a head ref
  • 12 commits
  • 82 files changed
  • 10 contributors

Commits on Apr 2, 2024

  1. JIT: Add separate ABI classifiers for x86/win-x64/SysV-x64/ARM64 (#10…

    …0276)
    
    While trying to implement struct support for Swift reverse pinvokes I ended up
    having to factor the ABI classification out of `lvaInitUserArgs` to be able to
    invoke it multiple times for structs. In the end that led me to do the work to
    split out the ABI classification into a different classifier for each ABI.
    
    ARM32, LA64 and RV64 still need to be split out.
    
    We still don't actually use this information for anything, but it's asserted
    that it is correct. We are going to be using it in the backend for Swift reverse
    pinvokes, and I expect to move more and more things to use it and get completely
    rid of the ABI classification within `lvaInitUserArgs` (and in the long run
    hopefully `CallArgs::AddFinalArgsAndDetermineABIInfo`).
    
    Another todo: this classification should be where we determine whether something
    is passed implicit by reference instead of doing that in
    `lvaSetStruct`/`getArgTypeForStruct`.
    jakobbotsch authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    10e87bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    991a054 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef86661 View commit details
    Browse the repository at this point in the history
  4. Add JitOptRepeat to JIT experimental AzDO pipeline (#100326)

    Add one job that runs JitOptRepeat on all functions, 2 repetitions.
    BruceForstall authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f37a5c1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    93483ba View commit details
    Browse the repository at this point in the history
  6. Fix more diagnostics with CA2263 (#100490)

    * Fix more diagnostics with CA2263
    
    * Apply feedbacks
    buyaa-n authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1ec64a7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    43dfccd View commit details
    Browse the repository at this point in the history
  8. SPMI: Fix Python 3.12 warnings in superpmi.py (#100533)

    Python 3.12 prints some warnings when parsing superpmi.py due to some
    insufficiently escaped characters in some strings.
    jakobbotsch authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a8daf55 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    254012e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    995989e View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Enable FEATURE_PERFMAP on OSX, and update perfjitdump.cpp to work on …

    …OSX (#99986)
    
    * Enable FEATURE_PERFMAP on OSX, and update perfjitdump.cpp to work on OSX
    
    * Update PerfMapEnabled documentation
    
    * Enable only on OSX, and use PlatformGetCurrentThreadId
    
    * Manual mach_absolute_time calls
    
    * Use QueryPerformanceCounter
    
    * Cleaner QueryPerformanceFrequency verification
    
    * Use FEATURE_PERFMAP
    
    * Put back conditional, but all __APPLE__
    
    * Fix logic error when disabling jitdump
    vvuk authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e020a93 View commit details
    Browse the repository at this point in the history
  2. Cleanup of fx_resolver_t and tests in NativeHostApis (#100542)

    Slight cleanup of `fx_resolver_t` and `NativeHostApis` tests in preparation for #99027:
    - Collapse `reconcile_fx_references_helper` into `reconcile_fx_references`
    - Make `NativeHostApis` tests / `HostApiInvokerApp` more consistent in how they log and validate results
    elinor-fung authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    85e8f68 View commit details
    Browse the repository at this point in the history
Loading