Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5795e8c0
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a2b7214a
Choose a head ref
  • 9 commits
  • 111 files changed
  • 9 contributors

Commits on Jul 9, 2024

  1. [cdac] Implement ISOSDacInterface2::GetObjectExceptionData (#104343)

    - Make cDac implement `ISOSDacInterface2`
    - Add `Exception` (managed type) to data descriptor
    - Add `GetExceptionData` to `Exception` contract which gets all the data that SOS-DAC API uses
    elinor-fung authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e733c2f View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Add standard tags to HttpClient native trace instrumentation (#104251)

    Add the following standard tags to the HTTP Request Activities started in DelegatingHandler:
    
    http.request.method
    http.request.method_original
    server.address
    server.port
    url.full
    
    error.type
    http.response.status_code
    network.protocol.version
    
    Just like in #103769, url.full is being redacted by removing UserInfo and the query string, while exposing a System.Net.Http.DisableQueryRedaction switch for opting-out from the latter.
    antonfirsov authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c7fa446 View commit details
    Browse the repository at this point in the history
  2. Implement various other simple vector APIs from 93513 (#103837)

    * Update Vector<T> to implement ISimdVector<TSelf, T>
    
    * Expose various constants for Vector2/3/4
    
    * Expose Exp, Log, and Log2 on the other vector types
    
    * Expose CopySign on the vector types
    
    * Expose DegreesToRadians and RadiansToDegrees on the vector types
    
    * Expose Hypot on the vector types
    
    * Expose Lerp on the vector types
    
    * Expose Truncate and Round on the vector types
    
    * Cleanup some of the implementations to use helper functions where possible
    
    * Expose Max, MaxMagnitude, MaxMagnitudeNumber, MaxNumber, Min, MinMagnitude, MinMagnitudeNumber, and MinNumber for the vector types
    
    * Expose Clamp on the various vector types
    
    * Ensure mono handles the various zero and low-cost vector conversions
    
    * Apply formatting patch
    
    * Ensure that TensorPrimitives uses the in-box vector operations on .NET 9+
    
    * Fix some build failures
    
    * Workaround a MonoJIT assertion
    
    * Ensure Hypot for double handles insignificant results
    
    * Remove part of the mono changes that were extracted to a separate PR
    
    * Apply suggestions from code review
    
    Co-authored-by: Stephen Toub <[email protected]>
    
    * Ensure tests are added for the new vector APIs
    
    * Fix the mono handling for IsNaN, IsNegative, and IsPositive
    
    * Use the right op for WASM
    
    * Fix a round test to correctly expect -0
    
    * Fix some tests where the wrong parameter counts were being passed
    
    * Ensure APIs are correctly handled for Vector<T>
    
    * Fix the mono handling for OP_XCOMPARE_FP
    
    * Have Mono use the proper klass for IsPositive/IsNegative since we're reinterpreting
    
    * Ensure Mono looks up the class namespace
    
    * Ensure mono inserts xcast where required and handles MultiplyAddEstimate
    
    * Add missing underscores to fix the mono build
    
    * Add the if is_element_type_primitive check to MultiplyAddEstimate for mono
    
    * Pass the right klass on Mono
    
    * Ensure mono sets the metadata for add_ins
    
    * Ensure mono passes down the cast arg0
    
    * Fix the lerp for Mono to match the managed impl
    
    * Ensure mono lerp uses ins_amount for scaling y
    
    * Use gtCloneExpr after the first fgMakeMultiUse if we need another copy
    
    * Combine the SN_IsNegative and SN_IsPositive logic
    
    * Update src/mono/mono/mini/simd-intrinsics.c
    
    ---------
    
    Co-authored-by: Stephen Toub <[email protected]>
    tannergooding and stephentoub authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4a1a076 View commit details
    Browse the repository at this point in the history
  3. Use GetTempPath2 on Windows if available (#104642)

    Since Windows 10 Build 20348, there is a new API to get the temporary files path called [`GetTempPath2`](https://learn.microsoft.com/windows/win32/api/fileapi/nf-fileapi-gettemppath2w). This API returns a directory inaccessible to non-SYSTEM processes if the calling process runs as SYSTEM, and [it is recommended to call this function instead of `GetTempPath`](https://learn.microsoft.com/windows/win32/api/fileapi/nf-fileapi-gettemppathw#remarks).
    
    This PR tries to find `GetTempPath2A` / `GetTempPath2W` and uses that, otherwise it falls back to `GetTempPathA` / `GetTempPathW`.
    
    *Note:* this PR removes an unused function `GetTempPathWrapper` that which referenced `GetTempPathW`
    
    Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]>
    tommcdon and hoyosjs authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e3d2dd1 View commit details
    Browse the repository at this point in the history
  4. Add support for Sve.Scatter() (#104555)

    * Add support for Sve.Scatter()
    
    * Fix XML formatting error
    
    * Address review comments
    SwapnilGaikwad authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c52fd37 View commit details
    Browse the repository at this point in the history
  5. JIT: Account for mixed-enregistered locals when zeroing without block…

    …-init (#104593)
    
    Locals that are in registers at the beginning of a function do not need
    to have their stack home zeroed. `genFnProlog` already skips these
    locals when computing the range of bytes to zero; however,
    `genZeroInitFrame` was not doing the same in the non-block init case,
    which does not make use of the range computed by `genFnProlog`. This
    could cause an unbounded amount of (unnecessary) codegen during
    zero-initing, which is not legal to have in the prolog.
    
    Fix #104570
    jakobbotsch authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d586986 View commit details
    Browse the repository at this point in the history
  6. JIT: Disallow implicit byref args and return buffers from aliasing (#…

    …104616)
    
    The recent work to allow more retbuf definitions uncovered cases where
    we would end up with the retbuffer aliasing an implicit byref argument.
    The JIT does not handle this aliasing, which would require proper
    `GTF_GLOB_REF` flags on the local nodes accesses implicit byrefs. Fix
    the problem by disallowing last-use copy elision when the local would
    alias the return buffer.
    
    Fix #104613
    jakobbotsch authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    6c55362 View commit details
    Browse the repository at this point in the history
  7. JIT: Skip switch recognition for handles (#104634)

    Recognizing a series of handle compares as a switch is not legal since
    those handles may change values.
    jakobbotsch authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cd9cc87 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a2b7214 View commit details
    Browse the repository at this point in the history
Loading