Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 102d1e8
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d261384
Choose a head ref
  • 14 commits
  • 75 files changed
  • 13 contributors

Commits on Mar 29, 2021

  1. Added LoggerMessage.Define overloads to disable IsEnabled check (#50334) 

    - LoggerMessage.Define with overload to disable IsEnabled check
- Hoist skipEnabledCheck
    @gfoidl
    gfoidl authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    3b0c4e4 View commit details
    Browse the repository at this point in the history

  2. Reenable threadstart tests. (#50343) 

    The failures do not look jit-related. If they fail again please open another issue.
    Sergey Andreenko authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    ff465c7 View commit details
    Browse the repository at this point in the history

  3. JIT: tolerate edge profile inconsistencies better. (#50213) 

    We should not blow up jitting just because edge counts are inconsistent.

Also, make sure we're not doing any guarded devirt if we disable pgo.

And, add an option JitEnablePgoRange to selectively enable use of PGO for
problem isolation.
    @AndyAyersMS
    AndyAyersMS authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    a55b7e0 View commit details
    Browse the repository at this point in the history

  4. Do not mutate IEnumerable and null values when formatting (#49228) 

    Co-authored-by: Stephen Toub <[email protected]>
    @pergardebrink @stephentoub
    pergardebrink and stephentoub authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    8fc5789 View commit details
    Browse the repository at this point in the history

  5. [main] Update dependencies from mono/linker (#50232) 

    * Update dependencies from https://github.com/mono/linker build 20210324.1

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21174.1

* Update dependencies from https://github.com/mono/linker build 20210326.1

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21176.1

* Update dependencies from https://github.com/mono/linker build 20210327.1

Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.2.21172.2 -> To Version 6.0.100-preview.2.21177.1

* Add missing annotations

* Always keep ValueType constructor

* Fix exceptions descriptors to match what native lookup expects

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Marek Safar <[email protected]>
    @dotnet-maestro @marek-safar
    3 people authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    860518b View commit details
    Browse the repository at this point in the history

  6. Fix typo in comment in BitOperation.cs

    @stephentoub
    stephentoub authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    473f8f6 View commit details
    Browse the repository at this point in the history

  7. Use a NewHolder for pEmitter to avoid memory leak (#50242) 

    It seems like we are allocating memory, but never releasing it.
    @omajid
    omajid authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    93b8e18 View commit details
    Browse the repository at this point in the history

  8. Propagate XUnitMethodName/XUnitClassName properties to Android test r… 

    …unner (#50295)
    @elinor-fung
    elinor-fung authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    de867a9 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary delegate/closure allocations from PollForValues (#… 

    …50357)

It allocates a delegate/closure for each counter group each time the loop runs.
    @stephentoub
    stephentoub authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    3870c9f View commit details
    Browse the repository at this point in the history

  10. [wasm] Wasm.Build.Tests: add support for shared builds (#49398) 

    * [wasm] Wasm.Build.Tests: add support for shared builds

- Essentially, we want to share builds wherever possible. Example cases:

    - Same build, but run with different hosts like v8/chrome/safari, as
      separate test runs
    - Same build but run with different command line arguments

- Sharing builds especially helps when we are AOT'ing, which is slow!

- This is done by caching the builds with the key:

    `public record BuildArgs(string ProjectName, string Config, bool AOT, string ProjectFileContents, string? ExtraBuildArgs);`

- Also, ` SharedBuildClassFixture` is added, so that the builds can be
  cleaned up after all the tests in a particular class have finished
  running.

- Each test run gets a randomly generated test id. This is used for
  creating:
  1. build paths, like `artifacts/bin/Wasm.Build.Tests/net6.0-Release/browser-wasm/xharness-output/logs/n1xwbqxi.ict`
  2. and the log for running with xharness, eg. for Chrome, are in
     `artifacts/bin/Wasm.Build.Tests/net6.0-Release/browser-wasm/xharness-output/logs/n1xwbqxi.ict/Chrome/`

- split `WasmBuildAppTest.cs` into : `BuildTestBase.cs`, and
  `MainWithArgsTests.cs`.

* [wasm] Wasm.Build.Tests: Add test for relinking with InvariantGlobalization

* [wasm] Wasm.Build.Tests - Check `CultureInfo` for invariant culture

.. tests. Code stolen from @maximlipin's #49204

* fix invariant+aot test

* [wasm] Fix the order of include paths

For AOT we generate `pinvoke-table.h` in the obj directory. But there is
one present in the runtime pack too.

In my earlier changes the order in which these were passed as include
search paths was changed from:

`"-I/runtime/pack/microsoft.netcore.app.runtime.browser-wasm/Release/runtimes/browser-wasm/native/include/wasm" "-Iartifacts/obj/mono/Wasm.Console.Sample/wasm/Release/browser-wasm/wasm/"`

.. which meant that the one from the runtime pack took precedence, and
got used. So, fix the order!

And change the property names to indicate where they are sourced from.

* [wasm] Only test with Release config on CI

* [wasm] Fallback to `dotnet xharness` if `XHARNESS_CLI_PATH` is not set.

The environment variable is set on helix. During local testing it can be
useful when using a locally built xharness.

* [wasm] fix invariant test - 'en-ES' -> 'es-ES'

* [wasm] RunWithEmSdkEnv: log the working directory also

* [wasm] Re-enable wasm build tests

* [wasm] Add regression test for issue #49588

* fix test

* [wasm] Cleanup, and add more tests

* Update tests to track wasm relinking being default in some cases

* Fix InvariantGlobalization to track change in wasm relinking defaults

* [wasm] Update emsdk check message to track changes

* [wasm] Update tests to track changes

* [wasm] Move Scenario=BuildWasmApps to be submitted first

TLDR;
- this might help with the job getting scheduled first, and thus having
  a chance at completing at the same time as others.

Reasoning:

The problem this is trying to fix is:

1. The helix step submits 3 jobs:
    a. library tests to be run with v8
    b. library tests to be run with browser (scenario=wasmtestonbrowser)
    c. Wasm.Build.Tests (scenario=buildwasmapps)

2. The 3 jobs, individually take roughly 30mins each
3. And they get submitted at roughly the same time
4. But .. the first two seem to complete earlier, and the 3rd one
   completes 25-30mins later.

The hypothesis is that all the machines might be busy processing the
200+ work items from each of the first two steps, and so
Wasm.Build.Tests get scheduled pretty late.

So, here we move that to be submitted first, in the hope that it would
be able to run in parallel with the other jobs.
    @radical
    radical authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    617a18d View commit details
    Browse the repository at this point in the history

  11. Remove some delegate/closures from X509Pal (#50376)

    @stephentoub
    stephentoub authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    c7ab19e View commit details
    Browse the repository at this point in the history

  12. Fix unintended closure in RsaPaddingProcessor.OpenProcessor (#50377)

    @stephentoub
    stephentoub authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    0124dbc View commit details
    Browse the repository at this point in the history

  13. Set IsTrimmable on CompilerServices.Unsafe (#50370) 

    Fixes #50354
    @sbomer
    sbomer authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    98ace7d View commit details
    Browse the repository at this point in the history

  14. Clean up REGUTIL/CLRConfig system (#50314) 

    * Convert all configuration options from REGUTIL to CLRConfig.

* Remove uses of REGUTIL outside of CLRConfig impl.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    d261384 View commit details
    Browse the repository at this point in the history
Loading