-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Comparing changes
Open a pull request
base repository: dotnet/runtime
base: 05cb7f5
head repository: dotnet/runtime
compare: 110cb9f
- 18 commits
- 157 files changed
- 19 contributors
Commits on Mar 17, 2022
-
* Remove dotnet6 feeds dotnet7 feeds are currently the target feeds for the main branch. The dotnet6 feeds shouldn't be used anymore. * Update targetingpacks.targets * Update prebuilt package versions * Update NativeExports.csproj
Configuration menu - View commit details
-
Copy full SHA for b5edcab - Browse repository at this point
Copy the full SHA b5edcabView commit details -
[mono] Merge icall-def-netcore.h back into icall-def.h (#66730)
This was originally done in mono/mono to allow building both legacy and netcore, but we don't need this split anymore in dotnet/runtime.
Configuration menu - View commit details
-
Copy full SHA for 7fc07e9 - Browse repository at this point
Copy the full SHA 7fc07e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac84ea6 - Browse repository at this point
Copy the full SHA ac84ea6View commit details -
Structs: Do not mark "Hidden buffer pointer" as address-exposed (#64130)
* Preliminary changes * Add the missing push of ssadef * Fix an issue for call tree cloning * formatting * minor review comments incorporation * Make GT_CALL as full-def * Merge RenameCall into RenameDef * Fix DefinesLocalAddr and lateuse arg * Minor comments * fix the recently added code to account that GT_CALL can also have defintion: * clone the return buffer arg * Another round of review comments * Handle return buffer calls in optIsVarAssgCB * Update locals defined by calls in NodeInfo * Fix a case where arg can be putarg * Restructure the cases in GetLclRetBufArgNode() * move ivaMaskCall outside the condition * Add back to call for DoNotEnregister which was missed for Release builds * Retrieve the appropriate node in case of copyReload * Added an assert * remove assert and add comment
Configuration menu - View commit details
-
Copy full SHA for c032e0d - Browse repository at this point
Copy the full SHA c032e0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 048da75 - Browse repository at this point
Copy the full SHA 048da75View commit details -
Configuration menu - View commit details
-
Copy full SHA for de2db69 - Browse repository at this point
Copy the full SHA de2db69View commit details -
Temporarily disable HttpClientTest.GetContentAsync_WhenCanNotConnect_…
…ExceptionContainsHostInfo on OSX (#66761)
Configuration menu - View commit details
-
Copy full SHA for 575100e - Browse repository at this point
Copy the full SHA 575100eView commit details -
Surface native sourcelink on CoreCLR native PDBs for easier dump debu…
…gging (#66677) * Use managed sourcelink infrastructure to allow for win native sourcelink
Configuration menu - View commit details
-
Copy full SHA for 200a11c - Browse repository at this point
Copy the full SHA 200a11cView commit details -
Add additional trace to HttpConnectionPool (#66605)
The additional trace should help troubleshoot hanged "pending" connection issues (i.e. the reasons why new connections were not created) in HttpConnectionPool. The issue manifests as growing number of timeouted requests. It is not easy to link a timeouted request (esp. with a small timeout) to a connection that was created 3 minutes ago but still is not connected. There are no traces of the state of HttpConnectionPool, e.g. number of pending connections, so it is unclear from existing traces why the pool decided not to create a connection. Related to #66297
Configuration menu - View commit details
-
Copy full SHA for bd02b32 - Browse repository at this point
Copy the full SHA bd02b32View commit details -
[wasm][debugger] Don't show the wasm functions on callstack when debu…
Configuration menu - View commit details
-
Copy full SHA for 15db6e0 - Browse repository at this point
Copy the full SHA 15db6e0View commit details -
[wasm][debugger] Fix incompatibility between runtime and nuget package (
#66295) * Fix incompatibility between runtime and nuget package * Update debug.ts
Configuration menu - View commit details
-
Copy full SHA for a1bc0f3 - Browse repository at this point
Copy the full SHA a1bc0f3View commit details -
Ensure the generic math interfaces are implemented implicitly where p…
…ossible (#66748) * Updating generic math interfaces to be implicitly implemented where possible * Resolve a build error in OdbcConnection caused by new Parse APIs * Revert "Resolve a build error in OdbcConnection caused by new Parse APIs" This reverts commit 6fd7ec7. * Suppress CA1846 for System.Data.Odbc * Updating the xml doc comments for exposed constants
Configuration menu - View commit details
-
Copy full SHA for 7f2cdc5 - Browse repository at this point
Copy the full SHA 7f2cdc5View commit details -
Always append the "dll" extension for native libraries loads on Windo…
…ws (#66666) * Always append the "dll" extension for native libraries loads on Windows Due to case-sensitive file systems on Windows the runtime will now always append the ".dll" extension unless the name contains a trailing "." or a known loadable extensions. This is an attempt to mitigate the default Windows behavior that appends a ".DLL" which is rarely the casing used for Windows shared libraries. Co-authored-by: Jan Kotas <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 60478d2 - Browse repository at this point
Copy the full SHA 60478d2View commit details -
Reimplement stubs to improve performance (#65738)
* Reimplement stubs to improve performance This change implements `FixupPrecodeStub`, `PrecodeStub` and `CallCountingStub` using a new mechanism with fixed code and separate RW data. The `LoaderHeap` was updated to support a new kind of allocation using interleaved code and data pages to support this new mechanism. The JIT now generates code that uses indirection slot to jump to the methods using `FixupPrecode`, improving performance of the ASPNet plaintext benchmark by 3-4% depending on the target platform (measured on x64 Windows / Linux and arm64 Linux). I have also removed the Holders, as the stubs are naturally properly aligned due to the way they are allocated. There is now only a single variant of each stub, there are no long / short ones anymore as they are not needed - the indirect jumps we use now are not range limited. Most of the stubs stuff is now target agnostic and the originally split implementation is now in single place for all targets. Only a few constants are defined as target specific in these. The code for the stubs is no longer generated as bytes by C++ code, but rather written in asm and compiled. These precompiled templates are then used as a source to copy the code from. The x86 is a bit more complex than that due to the fact that it doesn't support PC relative indirect addressing, so we need to relocate all access to the data slots when generating the code pages. As a further improvement, we could generate just a single page of the code and then just map it many times. This is left for future work. ARM64 Unix differs from the other targets / platforms - there are various page sizes being used. So the asm templates are generated for 4k..64k page sizes and the variant is then picked at runtime based on the page size extracted from the OS. This also removes a lot of writeable mappings created for modifications of the stub code when W^X is enabled, in the plaintext benchmark they were reduced by 75%. That results in a significant reducing of the .NET application startup time with W^X enabled. I think the `LoaderHeap` would benefit from some refactoring, but I'd prefer leaving it for a follow up. It seems that for the sake of the review, it is better to keep it as is. The change also implements logging of number of mappings and their exact locations. This helped me to drive the work and I am planning to use it for further changes. It can be removed in the future once we reach a final state. There are still opportunities for improvement, but these stubs allowed me to scrape off the most significant portion of the mappings.
Configuration menu - View commit details
-
Copy full SHA for eb8460f - Browse repository at this point
Copy the full SHA eb8460fView commit details -
Implement missing SymUnmanaged* interfaces (#66650)
* Implement missing SymUnmanaged* interfaces * Add try-finally around GCHandle * Marshal interface argument to pinned pointer * Minor fixes * Address feedbacks from review
Configuration menu - View commit details
-
Copy full SHA for 0319010 - Browse repository at this point
Copy the full SHA 0319010View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c97244 - Browse repository at this point
Copy the full SHA 8c97244View commit details -
[main] Update dependencies from 8 repositories (#66539)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 731d936 - Browse repository at this point
Copy the full SHA 731d936View commit details
Commits on Mar 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 110cb9f - Browse repository at this point
Copy the full SHA 110cb9fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 05cb7f5...110cb9f