Skip to content

Commit e96321d

Browse files
ilonatommyilonatommy
authored
[wasm][debugger] Disable failing multithreading debugger tests (#86501)
* Block for multithreading. * Another failing test. * category - case matters. * Cleanup. * "Result reported for unknown test case" fix. Cannot be lazy. * Debugger has its own treading feature discovery. * Prevent trait filter from being overwritten. * Applied @radical's review, reverted `TEST_FILTER` removal with changes fixing the issue. * Makefiles - full revert, fix should be in msbuild. * Failing frequently. * Fleaky tests. * Now this one failed - block. * 10 min still timeouts, set to 15. * Revert "10 min still timeouts, set to 15." This reverts commit 2e008d4.
1 parent 268962e commit e96321d

File tree

9 files changed

+25
-13
lines changed

9 files changed

+25
-13
lines changed

‎src/mono/wasi/Makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ submit-tests-helix:
104104
run-debugger-tests:
105105
rm -f $(TOP)/artifacts/bin/DebuggerTestSuite/x64/Debug/*log; \
106106
if [ ! -z "$(TEST_FILTER)" ]; then \
107-
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "Category!=failing&FullyQualifiedName$(TEST_FILTER)" $(TEST_ARGS); \
107+
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "category!=failing&FullyQualifiedName$(TEST_FILTER)" $(TEST_ARGS); \
108108
else \
109-
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "Category!=failing" $(TEST_ARGS); \
109+
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "category!=failing" $(TEST_ARGS); \
110110
fi
111111

112112
build-dbg-proxy:

‎src/mono/wasm/Makefile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ submit-tests-helix:
148148
run-debugger-tests:
149149
rm -f $(TOP)/artifacts/bin/DebuggerTestSuite/x64/Debug/*log; \
150150
if [ ! -z "$(TEST_FILTER)" ]; then \
151-
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "Category!=failing&FullyQualifiedName$(TEST_FILTER)" $(TEST_ARGS); \
151+
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "category!=failing&FullyQualifiedName$(TEST_FILTER)" $(TEST_ARGS); \
152152
else \
153-
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "Category!=failing" $(TEST_ARGS); \
153+
$(DOTNET) test $(TOP)/src/mono/wasm/debugger/DebuggerTestSuite $(MSBUILD_ARGS) "-l:trx;LogFileName=DebuggerTestsResults.xml" --results-directory $(TOP)/artifacts/log/$(CONFIG) --filter "category!=failing" $(TEST_ARGS); \
154154
fi
155155

156156
build-dbg-proxy:

‎src/mono/wasm/debugger/DebuggerTestSuite/AssignmentTests.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public AssignmentTests(ITestOutputHelper testOutput)
5050

5151
[ConditionalTheory(nameof(RunningOnChrome))]
5252
[MemberData("GetTestData")]
53+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
5354
public async Task InspectVariableBeforeAndAfterAssignment(string clazz, JObject checkDefault, JObject checkValue, string methodName)
5455
{
5556
await SetBreakpointInMethod("debugger-test", "DebuggerTests." + clazz, "Prepare", 2);

‎src/mono/wasm/debugger/DebuggerTestSuite/AsyncTests.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public async Task AsyncLocalsInContinueWith(string method_name, string expected_
4444
});
4545

4646
[ConditionalFact(nameof(RunningOnChrome))]
47+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
4748
public async Task AsyncLocalsInContinueWithInstanceUsingThisBlock() => await CheckInspectLocalsAtBreakpointSite(
4849
"DebuggerTests.AsyncTests.ContinueWithTests", "ContinueWithInstanceUsingThisAsync", 5, "DebuggerTests.AsyncTests.ContinueWithTests.ContinueWithInstanceUsingThisAsync.AnonymousMethod__6_0",
4950
"window.setTimeout(function() { invoke_static_method('[debugger-test] DebuggerTests.AsyncTests.ContinueWithTests:RunAsync'); })",
@@ -66,6 +67,7 @@ public async Task AsyncLocalsInContinueWithInstanceUsingThisBlock() => await Che
6667
});
6768

6869
[Fact] // NestedContinueWith
70+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
6971
public async Task AsyncLocalsInNestedContinueWithStaticBlock() => await CheckInspectLocalsAtBreakpointSite(
7072
"DebuggerTests.AsyncTests.ContinueWithTests", "NestedContinueWithStaticAsync", 5, "DebuggerTests.AsyncTests.ContinueWithTests.NestedContinueWithStaticAsync",
7173
"window.setTimeout(function() { invoke_static_method('[debugger-test] DebuggerTests.AsyncTests.ContinueWithTests:RunAsync'); })",
@@ -140,7 +142,6 @@ await StepAndCheck(StepKind.Resume, source_to_pause, line2, col2, func_to_pause,
140142
public async Task InspectLocalsInAsyncVBMethod()
141143
{
142144
var expression = $"{{ invoke_static_method('[debugger-test-vb] DebuggerTestVB.TestVbScope:Run'); }}";
143-
144145
await EvaluateAndCheck(
145146
"window.setTimeout(function() {" + expression + "; }, 1);",
146147
"dotnet://debugger-test-vb.dll/debugger-test-vb.vb", 14, 12,

‎src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ await EvaluateAndCheck(
217217
[MemberData(nameof(FalseConditions))]
218218
[MemberData(nameof(TrueConditions))]
219219
[MemberData(nameof(InvalidConditions))]
220+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
220221
public async Task ConditionalBreakpoint2(string function_to_call, string method_to_stop, string condition, bool bp_stop_expected)
221222
{
222223
Result [] bps = new Result[2];
@@ -699,6 +700,7 @@ public async Task StepThroughOrNonUserCodeAttributeResumeWithBp(bool justMyCodeE
699700
[InlineData(true, "Debugger.stepInto", "RunStepThroughWithNonUserCode", "RunStepThroughWithNonUserCode", -1, 8, "RunStepThroughWithNonUserCode", -1, 4)]
700701
[InlineData(false, "Debugger.resume", "RunStepThroughWithNonUserCode", "StepThroughWithNonUserCodeUserBp", 927, 8, "RunStepThroughWithNonUserCode", -1, 4)]
701702
[InlineData(true, "Debugger.resume", "RunStepThroughWithNonUserCode", "RunStepThroughWithNonUserCode", -1, 8, "RunStepThroughWithNonUserCode", -1, 4)]
703+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
702704
public async Task StepThroughOrNonUserCodeAttributeWithUserBp(
703705
bool justMyCodeEnabled, string debuggingFunction, string evalFunName,
704706
string functionNameCheck1, int line1, int col1,

‎src/mono/wasm/debugger/DebuggerTestSuite/GetPropertiesTests.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ public GetPropertiesTests(ITestOutputHelper testOutput) : base(testOutput)
260260
[MemberData(nameof(ClassGetPropertiesTestData), parameters: false)]
261261
[MemberData(nameof(StructGetPropertiesTestData), parameters: true)]
262262
[MemberData(nameof(StructGetPropertiesTestData), parameters: false)]
263+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
263264
public async Task InspectTypeInheritedMembers(string type_name, bool? own_properties, bool? accessors_only, string[] expected_names, Dictionary<string, (JObject, bool)> all_props, bool is_async) =>
264265
await InspectTypeInheritedMembersInternal(type_name, own_properties, accessors_only, expected_names, all_props, is_async, AutoEvaluate.Unset);
265266

‎src/mono/wasm/debugger/DebuggerTestSuite/SetNextIpTests.cs‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-test.cs",
113113
}
114114

115115
[ConditionalFact(nameof(RunningOnChrome))]
116+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
116117
public async Task Lambda()
117118
{
118119
var debugger_test_loc = "dotnet://debugger-test.dll/debugger-async-test.cs";
@@ -159,6 +160,7 @@ await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-async-tes
159160
}
160161

161162
[ConditionalFact(nameof(RunningOnChrome))]
163+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
162164
public async Task Lambda_InvalidLocation()
163165
{
164166
var debugger_test_loc = "dotnet://debugger-test.dll/debugger-async-test.cs";
@@ -188,6 +190,7 @@ await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-async-tes
188190
}
189191

190192
[ConditionalFact(nameof(RunningOnChrome))]
193+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
191194
public async Task Lambda_ToNestedLambda()
192195
{
193196
var debugger_test_loc = "dotnet://debugger-test.dll/debugger-async-test.cs";
@@ -206,7 +209,7 @@ public async Task Lambda_ToNestedLambda()
206209

207210
await SetNextIPAndCheck(top_frame["scriptId"].Value<string>(), "dotnet://debugger-test.dll/debugger-async-test.cs", 88, 20, "DebuggerTests.AsyncTests.ContinueWithTests.NestedContinueWithInstanceAsync",
208211
expected_error: true);
209-
212+
210213
await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-async-test.cs", 79, 16, "DebuggerTests.AsyncTests.ContinueWithTests.NestedContinueWithInstanceAsync",
211214
locals_fn: async (locals) =>
212215
{
@@ -218,6 +221,7 @@ await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-async-tes
218221
}
219222

220223
[ConditionalFact(nameof(RunningOnChrome))]
224+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
221225
public async Task Lambda_ToNestedSingleLineLambda_Invalid()
222226
{
223227
var debugger_test_loc = "dotnet://debugger-test.dll/debugger-async-test.cs";
@@ -248,6 +252,7 @@ await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-async-tes
248252
}
249253

250254
[ConditionalFact(nameof(RunningOnChrome))]
255+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
251256
public async Task Lambda_ToNestedSingleLineLambda_Valid()
252257
{
253258
var debugger_test_loc = "dotnet://debugger-test.dll/debugger-async-test.cs";
@@ -271,7 +276,7 @@ await SetNextIPAndCheck(top_frame["scriptId"].Value<string>(), "dotnet://debugge
271276
await CheckValueType(locals, "code", "System.Threading.Tasks.TaskStatus", description: "Created");
272277
await CheckValueType(locals, "dt0", "System.DateTime", description: "1/1/0001 12:00:00 AM");
273278
});
274-
279+
275280
await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-async-test.cs", 92, 12, "DebuggerTests.AsyncTests.ContinueWithTests.NestedContinueWithInstanceAsync",
276281
locals_fn: async (locals) =>
277282
{

‎src/mono/wasm/debugger/DebuggerTestSuite/SteppingTests.cs‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -702,8 +702,8 @@ await EvaluateAndCheck(
702702
await StepAndCheck(StepKind.Over, "dotnet://debugger-test.dll/debugger-async-step.cs", 15, 12, "MoveNext");
703703
}
704704

705-
// [ConditionalFact(nameof(RunningOnChrome))]
706-
//[ActiveIssue("https://github.com/dotnet/runtime/issues/42421")]
705+
[ConditionalFact(nameof(RunningOnChrome))]
706+
[ActiveIssue("https://github.com/dotnet/runtime/issues/42421")]
707707
public async Task StepOutOfAsyncMethod()
708708
{
709709
string source_file = "dotnet://debugger-test.dll/debugger-async-step.cs";
@@ -865,8 +865,8 @@ await EvaluateAndCheck(
865865
method_name);
866866
}
867867

868-
// [ConditionalTheory(nameof(RunningOnChrome))]
869-
//[ActiveIssue("https://github.com/dotnet/runtime/issues/73867")]
868+
[ConditionalTheory(nameof(RunningOnChrome))]
869+
[ActiveIssue("https://github.com/dotnet/runtime/issues/73867")]
870870
[InlineData(184, 20, 161, 8, "HiddenLinesContainingStartOfAnAsyncBlock")]
871871
[InlineData(206, 20, 201, 8, "HiddenLinesAtTheEndOfANestedAsyncBlockWithWithLineDefaultOutsideTheMethod")]
872872
[InlineData(224, 20, 220, 8, "HiddenLinesAtTheEndOfANestedAsyncBlockWithWithLineDefaultOutsideTheMethod2")]
@@ -885,6 +885,7 @@ await EvaluateAndCheck(
885885
[InlineData(153, 20, 155, 16, "HiddenLinesAtTheEndOfANestedAsyncBlockWithNoLinesAtEndOfTheMethod.AnonymousMethod__1")]
886886
[InlineData(154, 20, 155, 16, "HiddenLinesAtTheEndOfANestedAsyncBlockWithNoLinesAtEndOfTheMethod.AnonymousMethod__1")]
887887
[InlineData(170, 20, 172, 16, "HiddenLinesAtTheEndOfANestedAsyncBlockWithBreakableLineAtEndOfTheMethod.AnonymousMethod__1")]
888+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
888889
public async Task BreakpointOnHiddenLineShouldStopAtEarliestNextAvailableLineAsync(int line_bp, int column_bp, int line_pause, int column_pause, string method_name)
889890
{
890891
await SetBreakpoint("dotnet://debugger-test.dll/debugger-async-test.cs", line_bp, column_bp);
@@ -1219,6 +1220,7 @@ await StepAndCheck(StepKind.Into, "dotnet://Newtonsoft.Json.dll/JArray.cs", 350,
12191220
[ConditionalTheory(nameof(RunningOnChrome))]
12201221
[InlineData(true)]
12211222
[InlineData(false)]
1223+
[ActiveIssue("https://github.com/dotnet/runtime/issues/86496", typeof(DebuggerTests), nameof(DebuggerTests.WasmMultiThreaded))]
12221224
public async Task SkipWasmFunctionsAccordinglyJustMyCode(bool justMyCode)
12231225
{
12241226
await SetJustMyCode(justMyCode);

‎src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
<PayloadArchive>$(TestArchiveTestsDir)Wasm.Debugger.Tests.zip</PayloadArchive>
2828
<Command>$(HelixCommand)</Command>
2929
<Timeout>$(_DebuggerTestsWorkItemTimeout)</Timeout>
30-
<PreCommands Condition="'$(OS)' == 'Windows_NT'">set &quot;TEST_ARGS=--filter FullyQualifiedName~%(Identity)&quot;</PreCommands>
31-
<PreCommands Condition="'$(OS)' != 'Windows_NT'">export &quot;TEST_ARGS=--filter FullyQualifiedName~%(Identity)&quot;</PreCommands>
30+
<PreCommands Condition="'$(OS)' == 'Windows_NT'">set &quot;TEST_ARGS=--filter category!=failing&amp;FullyQualifiedName~%(Identity)&quot;</PreCommands>
31+
<PreCommands Condition="'$(OS)' != 'Windows_NT'">export &quot;TEST_ARGS=--filter category!=failing&amp;FullyQualifiedName~%(Identity)&quot;</PreCommands>
3232
</HelixWorkItem>
3333
</ItemGroup>
3434
</Target>

0 commit comments

Comments
 (0)