Repository navigation
Commit d42a835
Use safe code for UTF-8 StartsWith(OrdinalIgnoreCase) (#134857)
Rewrites `Ordinal.StartsWithIgnoreCaseUtf8`, which backs
`MemoryExtensions.StartsWithOrdinalIgnoreCaseUtf8`, using safe
span-based code. There's no `Unsafe.*` or `MemoryMarshal.*`.
Its only caller is UTF-8 floating-point parsing: once the numeric parse
fails, the parser matches
`NumberFormatInfo.PositiveSign`/`NegativeSign`. Across all 890 ICU
cultures, these signs are 1 byte in ~94% of cultures and at most 7 bytes
(`U+200E + U+200E`).
So the vectorized and unrolled paths are replaced with:
- **An inlined fast path for a single ASCII byte prefix:** it's inlined
into the parsing code, so the common `+`/`-` case doesn't call out of
line.
- **A single loop for everything else:** ASCII bytes are compared
inline, and runes are decoded only when both sides are non-ASCII.
### Behavior changes
- **`Rune.ToUpperOrdinal` instead of `Rune.ToUpperInvariant`:**
non-ASCII runes now use the same casing as UTF-16 `OrdinalIgnoreCase`,
with no ICU call per rune.
- `ſ` (U+017F) no longer matches `s`.
- Some newer scalars (e.g. Garay U+10D70–U+10D85) now match their
uppercase forms, as they do in UTF-16.
- **Immediate rejection of an ASCII byte against a non-ASCII byte:** no
non-ASCII scalar uppercases to ASCII under ordinal casing.
- **Fixes for bugs in the previous implementation:**
- **3-byte tail with non-ASCII data:** it created spans extending up to
2 bytes past the end of both inputs. For example, `"aé"`/`"aÉ"` returned
`false` and `"aé"`/`"bé"` returned `true`.
- **Prefix longer than the source (both ≥ 16 bytes):** it could match.
For example, `"Content-Length: 1234"`/`"content-length: 1234x"` returned
`true`.
- **ASCII vs. non-ASCII:** results depended on block alignment.
### Benchmarks
`double.TryParse` on UTF-8 input; [EgorBot
results](EgorBot/Benchmarks#629). `PR/main`
below 1.00 is faster.
#### macOS arm64 — Apple M4
| Case | PositiveSign / NegativeSign | Input | main | PR | PR/main |
|---|---|---|---:|---:|---:|
| Inv_PlusInfinity | `+` / `-` | `+infinity` | 19.68 ns | 19.43 ns |
0.99 |
| Inv_PlusNaN_Upper | `+` / `-` | `+NAN` | 18.80 ns | 17.99 ns | 0.96 |
| Inv_MinusNaN | `+` / `-` | `-nan` | 24.20 ns | 22.74 ns | 0.94 |
| Inv_Invalid | `+` / `-` | `abc` | 22.40 ns | 20.70 ns | 0.92 |
| Inv_NonAsciiInput | `+` / `-` | `∞` | 22.61 ns | 21.15 ns | 0.94 |
| U2212_MinusNaN | `+` / `U+2212` | `U+2212` `nan` | 26.44 ns | 27.07 ns
| 1.02 |
| U2212_HyphenNaN | `+` / `U+2212` | `-nan` | 26.40 ns | 25.09 ns | 0.95
|
| U2212_Invalid | `+` / `U+2212` | `abc` | 22.32 ns | 21.41 ns | 0.96 |
| LRM_PlusInfinity | `LRM+LRM` / `LRM-LRM` | `LRM+LRMinfinity` | 61.32
ns | 29.04 ns | 0.47 |
| LRM_PlainPlusInfinity | `LRM+LRM` / `LRM-LRM` | `+infinity` | 22.60 ns
| 22.50 ns | 1.00 |
| LRM_Invalid | `LRM+LRM` / `LRM-LRM` | `abc` | 21.81 ns | 21.20 ns |
0.97 |
| `double.Parse("-nan"u8)` | invariant | `-nan` | 24.81 ns | 23.30 ns |
0.94 |
#### Linux x64 — AMD EPYC 9V45
| Case | PositiveSign / NegativeSign | Input | main | PR | PR/main |
|---|---|---|---:|---:|---:|
| Inv_PlusInfinity | `+` / `-` | `+infinity` | 25.75 ns | 24.72 ns |
0.96 |
| Inv_PlusNaN_Upper | `+` / `-` | `+NAN` | 21.73 ns | 22.38 ns | 1.03 |
| Inv_MinusNaN | `+` / `-` | `-nan` | 26.57 ns | 30.05 ns | 1.13 |
| Inv_Invalid | `+` / `-` | `abc` | 24.00 ns | 23.41 ns | 0.98 |
| Inv_NonAsciiInput | `+` / `-` | `∞` | 25.23 ns | 24.75 ns | 0.98 |
| U2212_MinusNaN | `+` / `U+2212` | `U+2212` `nan` | 27.56 ns | 30.75 ns
| 1.12 |
| U2212_HyphenNaN | `+` / `U+2212` | `-nan` | 29.25 ns | 29.06 ns | 0.99
|
| U2212_Invalid | `+` / `U+2212` | `abc` | 24.97 ns | 23.98 ns | 0.96 |
| LRM_PlusInfinity | `LRM+LRM` / `LRM-LRM` | `LRM+LRMinfinity` | 69.76
ns | 31.65 ns | 0.45 |
| LRM_PlainPlusInfinity | `LRM+LRM` / `LRM-LRM` | `+infinity` | 26.33 ns
| 27.20 ns | 1.03 |
| LRM_Invalid | `LRM+LRM` / `LRM-LRM` | `abc` | 25.21 ns | 24.75 ns |
0.98 |
| `double.Parse("-nan"u8)` | invariant | `-nan` | 26.90 ns | 26.05 ns |
0.97 |
#### Windows x64 — AMD EPYC 9V45
| Case | PositiveSign / NegativeSign | Input | main | PR | PR/main |
|---|---|---|---:|---:|---:|
| Inv_PlusInfinity | `+` / `-` | `+infinity` | 30.96 ns | 30.79 ns |
0.99 |
| Inv_PlusNaN_Upper | `+` / `-` | `+NAN` | 27.33 ns | 27.89 ns | 1.02 |
| Inv_MinusNaN | `+` / `-` | `-nan` | 32.68 ns | 32.47 ns | 0.99 |
| Inv_Invalid | `+` / `-` | `abc` | 31.75 ns | 28.53 ns | 0.90 |
| Inv_NonAsciiInput | `+` / `-` | `∞` | 32.68 ns | 34.31 ns | 1.05 |
| U2212_MinusNaN | `+` / `U+2212` | `U+2212` `nan` | 34.11 ns | 37.55 ns
| 1.10 |
| U2212_HyphenNaN | `+` / `U+2212` | `-nan` | 36.61 ns | 39.84 ns | 1.09
|
| U2212_Invalid | `+` / `U+2212` | `abc` | 29.60 ns | 29.22 ns | 0.99 |
| LRM_PlusInfinity | `LRM+LRM` / `LRM-LRM` | `LRM+LRMinfinity` | 80.27
ns | 37.68 ns | 0.47 |
| LRM_PlainPlusInfinity | `LRM+LRM` / `LRM-LRM` | `+infinity` | 31.53 ns
| 33.44 ns | 1.06 |
| LRM_Invalid | `LRM+LRM` / `LRM-LRM` | `abc` | 38.33 ns | 30.76 ns |
0.80 |
| `double.Parse("-nan"u8)` | invariant | `-nan` | 33.84 ns | 36.07 ns |
1.07 |
`LRM` is U+200E.
---------
Co-authored-by: Copilot <[email protected]>
Copilot-Session: 48e318b5-e3dd-40ea-84a9-c5c0b05926601 parent a1cdbbb commit d42a835
3 files changed
Lines changed: 69 additions & 285 deletions
File tree
- src/libraries
- System.Private.CoreLib/src/System
- Globalization
- System.Runtime/tests/System.Runtime.Tests/System
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
329 | | - | |
| 329 | + | |
| 330 | + | |
330 | 331 | | |
331 | 332 | | |
332 | 333 | | |
333 | 334 | | |
334 | 335 | | |
335 | 336 | | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
| 337 | + | |
342 | 338 | | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
| 339 | + | |
352 | 340 | | |
| 341 | + | |
353 | 342 | | |
354 | 343 | | |
355 | | - | |
356 | 344 | | |
357 | | - | |
358 | | - | |
359 | | - | |
360 | | - | |
361 | | - | |
| 345 | + | |
| 346 | + | |
362 | 347 | | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
377 | | - | |
378 | | - | |
379 | | - | |
| 348 | + | |
380 | 349 | | |
381 | | - | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
| 350 | + | |
| 351 | + | |
388 | 352 | | |
389 | | - | |
390 | 353 | | |
391 | 354 | | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | | - | |
473 | | - | |
474 | | - | |
475 | | - | |
476 | | - | |
477 | | - | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
482 | | - | |
483 | | - | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
498 | 355 | | |
499 | | - | |
500 | | - | |
501 | | - | |
502 | | - | |
503 | | - | |
504 | | - | |
505 | | - | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
506 | 359 | | |
507 | 360 | | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
| 361 | + | |
516 | 362 | | |
| 363 | + | |
517 | 364 | | |
518 | 365 | | |
519 | 366 | | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | | - | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
527 | 370 | | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
542 | | - | |
543 | | - | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | | - | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | | - | |
552 | | - | |
553 | | - | |
554 | | - | |
555 | | - | |
556 | | - | |
557 | | - | |
558 | | - | |
559 | | - | |
560 | | - | |
561 | | - | |
562 | | - | |
563 | | - | |
564 | | - | |
565 | | - | |
566 | | - | |
567 | | - | |
568 | | - | |
569 | | - | |
570 | | - | |
571 | | - | |
572 | | - | |
573 | | - | |
574 | | - | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
581 | | - | |
582 | | - | |
583 | | - | |
584 | | - | |
585 | | - | |
586 | | - | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | | - | |
595 | | - | |
596 | | - | |
| 371 | + | |
597 | 372 | | |
598 | | - | |
599 | 373 | | |
600 | 374 | | |
601 | 375 | | |
602 | | - | |
| 376 | + | |
603 | 377 | | |
604 | | - | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
605 | 382 | | |
606 | | - | |
607 | | - | |
| 383 | + | |
608 | 384 | | |
| 385 | + | |
609 | 386 | | |
610 | 387 | | |
611 | 388 | | |
612 | | - | |
613 | | - | |
614 | | - | |
615 | | - | |
616 | | - | |
617 | | - | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | | - | |
622 | | - | |
623 | | - | |
624 | | - | |
625 | | - | |
626 | | - | |
627 | | - | |
628 | | - | |
629 | | - | |
630 | | - | |
631 | | - | |
632 | | - | |
| 389 | + | |
| 390 | + | |
633 | 391 | | |
634 | | - | |
635 | | - | |
636 | | - | |
637 | 392 | | |
638 | | - | |
639 | | - | |
640 | | - | |
| 393 | + | |
641 | 394 | | |
642 | 395 | | |
643 | 396 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
| 67 | + | |
76 | 68 | | |
77 | 69 | | |
78 | 70 | | |
0 commit comments