You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b876d4e
Browse filesBrowse the repository at this point in the historyBrowse files
Defer WinHTTP HTTP/2 loopback connection closure until server disposal (#134181)
<!-- -->
WinHTTP can discard buffered response data when the loopback server
sends FIN before the client consumes it, causing error 12030. This
affects more than cookie tests: the same failure signature also appeared
in `ClientCertificateTest.UseClientCertOnHttp2_OSSupportsIt_Success`.
Synchronizing individual tests leaves other paths exposed.
This change moves lifetime management into the shared HTTP/2 loopback
infrastructure. In WinHTTP tests, connection disposal sends GOAWAY but
retains the transport until the enclosing server is disposed, normally
after both client and server callbacks complete. Retired connections do
not prevent subsequent connections from being accepted. Automatic GOAWAY
respects earlier last-stream boundaries, and cleanup tolerates the
server closing a connection during asynchronous disposal.
The behavior is enabled by default only for WinHTTP tests. Explicit
shutdown methods remain immediate, and tests requiring the original
disposal behavior can set `DeferConnectionClose = false`. The HTTP/2
cookie tests quarantined under #126867 are re-enabled; no
cookie-specific synchronization or product code changes are needed.
### Validation
- WinHTTP functional suites: 1,749 tests on .NET 11 and 667 on .NET
Framework, with zero failures and 41/28 existing skips respectively.
- WinHTTP unit tests: 173 passed.
- SocketsHttpHandler HTTP/2 protocol and cookie tests: 212 passed.
- Ten repetitions of the affected cookie, certificate, and lifetime
tests: 800 passes, no failures or skips.
- Regression tests verify that responses remain readable after
connection disposal and that physical closure during deferred disposal
completes safely. Both regressions were checked against the
corresponding unfixed behavior. These verify the lifetime contract, not
a deterministic reproduction of native error 12030.
Fixes#133779Fixes#130458Fixes#126867
... and countless others that boil down to "Error 12030 calling
WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, 'The connection with the server
was terminated abnormally'."
> [!NOTE]
> This pull request description and changes were generated with GitHub
Copilot.
Co-authored-by: Copilot App <[email protected]>
0 commit comments