Repository navigation
Commit b386290
Re-enable wasm runtime tests excluded against closed issues (#136548)
Housekeeping: several browser/wasm CoreCLR runtime-test exclusions point
at issues that have since been fixed and closed. This removes the stale
ones and turns the remaining permanent limitations into capability-gated
skips.
## Re-enabled
| Tracking issue | Fixed by | Tests |
|---|---|---|
| #131925 (open) | #133547 (GC mode across catch resumption) |
`Loader/ContextualReflection` (browser CoreCLR) |
| #133219 | #133547 | `JIT/opt/ThrowHelper/NonVoidThrowHelper`,
`JIT/opt/Vectorization/UnrollEqualsStartsWith` |
| #133307 | #133624 (removed only one of its four exclusions) |
`JIT/Directed/array-il/complex3`, `JIT/Methodical/Arrays/huge/huge_b`,
`JIT/Methodical/VT/port/lcs_gcref` |
| #134976 | #134981 | `HardwareIntrinsics_General_r` / `_ro`
(`R2RIncompatible` on wasm) |
| #133303 (dup, TypeMap crossgen2 `FileNotFoundException` family) |
closed | `Interop/Interop.csproj` (`R2RIncompatible` on wasm) |
This also drops the `TestLibrary` references that #133463 added only to
support these `ActiveIssue`s.
## Permanent limitations, now gated on their capability
- `structpasstest` `TestPInvokeCallbacks` (previously an `ActiveIssue`
against closed #133565) marshals managed delegates to native callbacks.
CoreCLR on wasm (`FEATURE_PORTABLE_ENTRYPOINTS`) deliberately can't
create native-callable entrypoints at run time;
`COMDelegate::ConvertToCallback` throws
`PlatformNotSupported_DynamicEntrypoint`. The test is now
`[ConditionalFact(PlatformDetection.IsDynamicEntrypointSupported)]`,
using a new runtime-test predicate that is false only for CoreCLR on
wasm. The struct-passing tests next to it still run.
## Exposed by re-enabling Interop under wasm R2R
Interop's `R2RIncompatible` made `Interop.sh` exit before launching its
out-of-process tests, so two of them had never run in the browser R2R
lane:
- `Interop/PInvoke/Unresolved/UnresolvedPInvokeTests`: crossgen2 crashes
when `--strip-il-bodies` is used in non-composite mode (#136545). Marked
`R2RIncompatible` on browser until #136549 merges. That PR makes
crossgen2 reject the flag without `--composite` and moves it to
`CompositeCrossGen2TestExtraArguments`; whichever PR merges second drops
this exclusion.
- `Interop/ICustomMarshaler/ConflictingNames/MultipleALCs` loads
`CustomMarshaler.dll` from the test assembly's directory. Under wasm
ReadyToRun, `Assembly.Location` is empty, so it is now gated on
`[ConditionalFact(Utilities.HasAssemblyFiles)]`, the same predicate
`ContextualReflection` uses.
## Validation
Ran locally on browser-wasm CoreCLR Checked, both normally and with
`RunCrossGen2=1`. Every affected test either passes or reports the
intended skip. `HardwareIntrinsics_General_r` was run only with
`RunCrossGen2=1`.
Not run locally: WASI (the removed `wasm` exclusions also apply there,
and WASI R2R uses composite mode), `HardwareIntrinsics_General_ro`, and
the Methodical `_d2`/`_do`/`_ro` copies of `lcs_gcref`. The browser and
WASI R2R CI lanes cover these.
> [!NOTE]
> This PR description was generated with the assistance of GitHub
Copilot.
---------
Co-authored-by: Copilot App <[email protected]>1 parent 8cf4609 commit b386290
16 files changed
Lines changed: 8 additions & 32 deletions
File tree
- src/tests
- Common/CoreCLRTestLibrary
- Interop
- ICustomMarshaler/ConflictingNames
- PInvoke/Unresolved
- JIT
- Directed/array-il
- HardwareIntrinsics
- Methodical
- Arrays/huge
- VT/port
- structs/systemvbringup
- opt
- ThrowHelper
- Vectorization
- Loader/ContextualReflection
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
116 | 120 | | |
117 | 121 | | |
118 | 122 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 9 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | 9 | | |
15 | 10 | | |
16 | 11 | | |
| |||
46 | 41 | | |
47 | 42 | | |
48 | 43 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 44 | | |
55 | 45 | | |
56 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | 103 | | |
105 | 104 | | |
106 | 105 | | |
| |||
0 commit comments