Repository navigation
Commit aca18aa
authored
Ensure type loader templates for interface dispatch cells (#134774)
Fixes #134698.
The `TemplateConstructableTypes` was done on the canonicalized version
of the method, so `IEnumerable<Foo<T__Canon>>` would turn into
`IEnumerable<__Canon>` and we would forget a type loader template for
`Foo<T__Canon>>` is needed.
This bug is old, .NET Native (Project X one) likely had it too. It
requires a bit of bad luck to hit because normally the template would
show up elsewhere. The repro hit this due to interaction with interface
variance.1 parent 29be631 commit aca18aa
2 files changed
Lines changed: 48 additions & 7 deletions
File tree
- src
- coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis
- tests/nativeaot/SmokeTests/UnitTests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1252 | 1252 | | |
1253 | 1253 | | |
1254 | 1254 | | |
1255 | | - | |
1256 | | - | |
1257 | | - | |
1258 | | - | |
1259 | | - | |
| 1255 | + | |
| 1256 | + | |
1260 | 1257 | | |
1261 | | - | |
| 1258 | + | |
1262 | 1259 | | |
1263 | 1260 | | |
1264 | | - | |
| 1261 | + | |
1265 | 1262 | | |
1266 | 1263 | | |
1267 | 1264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| |||
2426 | 2427 | | |
2427 | 2428 | | |
2428 | 2429 | | |
| 2430 | + | |
| 2431 | + | |
| 2432 | + | |
| 2433 | + | |
| 2434 | + | |
| 2435 | + | |
| 2436 | + | |
| 2437 | + | |
| 2438 | + | |
| 2439 | + | |
| 2440 | + | |
| 2441 | + | |
| 2442 | + | |
| 2443 | + | |
| 2444 | + | |
| 2445 | + | |
| 2446 | + | |
| 2447 | + | |
| 2448 | + | |
| 2449 | + | |
| 2450 | + | |
| 2451 | + | |
| 2452 | + | |
| 2453 | + | |
| 2454 | + | |
| 2455 | + | |
| 2456 | + | |
| 2457 | + | |
| 2458 | + | |
| 2459 | + | |
| 2460 | + | |
| 2461 | + | |
| 2462 | + | |
| 2463 | + | |
| 2464 | + | |
| 2465 | + | |
| 2466 | + | |
| 2467 | + | |
| 2468 | + | |
| 2469 | + | |
| 2470 | + | |
| 2471 | + | |
| 2472 | + | |
2429 | 2473 | | |
2430 | 2474 | | |
2431 | 2475 | | |
| |||
0 commit comments