Skip to content

Commit a7a9b87

Browse files
radekdoulikCopilot
andauthored
[browser][CoreCLR] Gate remaining priority-1 outerloop failures (#131957)
## Summary - Gate exactly four EventPipe events-validation projects on CoreCLR browser because they use unsupported `Process.GetCurrentProcess` and Process/PID-based managed self-process `DiagnosticsClient` collection; browser diagnostics use JS/WebSocket clients instead. - Temporarily suppress the CoreCLR-browser `ContextualReflection` interpreter failure through its tracked #131925 ActiveIssue. - Clarify that Server GC is disabled on CoreCLR browser by design. - `b65423` and `readytorun/fieldlayout` are absent from this change: current main includes the underlying fixes from #132078 and #132172, and both restored tests now pass targeted browser validation. Related issues: #131321, #131898, #131925. ## Validation - Merged and validated current `origin/main` at `663c457b86ccd35743374676a69de5ed97bc3b14`; the Checked browser `clr+libs` baseline passed with 0 warnings and 0 errors. - `b65423` passed 3/3: browser default, browser `DOTNET_TieredCompilation=0`, and native macOS arm64 process-isolated execution, each with expected/actual exit code 100. - `fieldlayout` passed 2/2 in browser default and no-tiered modes after producing and loading its composite Crossgen2/R2R WASM image. - Removing the ContextualReflection ActiveIssue reproduced #131925 in 2/2 browser modes; the final gated browser runs passed 2/2, and native ContextualReflection executed successfully. - An ungated no-tiered `GCEvents` run reproduced the expected `Process.GetCurrentProcess` PlatformNotSupportedException; all four final EventPipe projects were gated from CoreCLR-browser builds. - 14/14 representative property evaluations matched the intended scope across CoreCLR browser, CoreCLR macOS, and browser Mono. - Final delta: exactly 6 files, 23 insertions, 3 deletions. `git diff --check origin/main..HEAD` passed. > [!NOTE] > This pull request description was generated by GitHub Copilot. Co-authored-by: Copilot App <[email protected]> Copilot-Session: 808c6867-a1ea-4256-a003-46c17785ad04
1 parent 77c175b commit a7a9b87

6 files changed

Lines changed: 23 additions & 3 deletions

File tree

‎src/tests/GC/API/GC/GetTotalAllocatedBytesServerGC.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<ServerGarbageCollection>true</ServerGarbageCollection>
88
<!-- DATAS heap-count adaptation is a CoreCLR Server GC behavior -->
99
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' != 'coreclr'">true</CLRTestTargetUnsupported>
10-
<!-- TODO: Re-enable when CoreCLR WebAssembly supports server GC.
11-
Tracked by https://github.com/dotnet/runtime/issues/131321. -->
10+
<!-- Server GC is disabled on CoreCLR browser by design; see the suppression
11+
inventory in https://github.com/dotnet/runtime/issues/131321. -->
1212
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">true</CLRTestTargetUnsupported>
1313
</PropertyGroup>
1414
<PropertyGroup>

‎src/tests/Loader/ContextualReflection/ContextualReflection.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public class Program : IProgram
3434

3535
[ActiveIssue("https://github.com/dotnet/runtimelab/issues/165", typeof(Utilities), nameof(Utilities.IsNativeAot))]
3636
[ActiveIssue("https://github.com/dotnet/runtime/issues/34072", TestRuntimes.Mono)]
37+
[ActiveIssue("https://github.com/dotnet/runtime/issues/131925", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
3738
[Fact]
3839
public static void TestEntryPoint()
3940
{
@@ -785,4 +786,3 @@ public void TestDynamicAssembly(bool collectibleContext)
785786
}
786787
}
787788
}
788-

‎src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.csproj‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
<PropertyGroup>
33
<!-- Needed for UnloadabilityIncompatible -->
44
<RequiresProcessIsolation>true</RequiresProcessIsolation>
5+
<!-- Browser does not support Process.GetCurrentProcess or the Process/PID-based managed
6+
self-process DiagnosticsClient used by this test; browser diagnostics use JS/WebSocket
7+
clients instead. See https://github.com/dotnet/runtime/issues/131898 and
8+
https://github.com/dotnet/runtime/issues/131321. -->
9+
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">true</CLRTestTargetUnsupported>
510
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
611
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
712
<CLRTestPriority>1</CLRTestPriority>

‎src/tests/tracing/eventpipe/eventsvalidation/GCEvents.csproj‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
<PropertyGroup>
33
<!-- Needed for UnloadabilityIncompatible -->
44
<RequiresProcessIsolation>true</RequiresProcessIsolation>
5+
<!-- Browser does not support Process.GetCurrentProcess or the Process/PID-based managed
6+
self-process DiagnosticsClient used by this test; browser diagnostics use JS/WebSocket
7+
clients instead. See https://github.com/dotnet/runtime/issues/131898 and
8+
https://github.com/dotnet/runtime/issues/131321. -->
9+
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">true</CLRTestTargetUnsupported>
510
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
611
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
712
<CLRTestPriority>1</CLRTestPriority>

‎src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.csproj‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
<PropertyGroup>
33
<!-- Needed for UnloadabilityIncompatible, GC.WaitForPendingFinalizers -->
44
<RequiresProcessIsolation>true</RequiresProcessIsolation>
5+
<!-- Browser does not support Process.GetCurrentProcess or the Process/PID-based managed
6+
self-process DiagnosticsClient used by this test; browser diagnostics use JS/WebSocket
7+
clients instead. See https://github.com/dotnet/runtime/issues/131898 and
8+
https://github.com/dotnet/runtime/issues/131321. -->
9+
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">true</CLRTestTargetUnsupported>
510
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
611
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
712
<CLRTestPriority>1</CLRTestPriority>

‎src/tests/tracing/eventpipe/eventsvalidation/SampleProfilerSampleType.csproj‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
<PropertyGroup>
33
<!-- Needed for UnloadabilityIncompatible -->
44
<RequiresProcessIsolation>true</RequiresProcessIsolation>
5+
<!-- Browser does not support Process.GetCurrentProcess or the Process/PID-based managed
6+
self-process DiagnosticsClient used by this test; browser diagnostics use JS/WebSocket
7+
clients instead. See https://github.com/dotnet/runtime/issues/131898 and
8+
https://github.com/dotnet/runtime/issues/131321. -->
9+
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">true</CLRTestTargetUnsupported>
510
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
611
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
712
<CLRTestPriority>1</CLRTestPriority>

0 commit comments

Comments
 (0)