Repository navigation
Commit 94157b0
[System.Text.Json] Fix ARM64 Utf8JsonReader regression (#132452)
Fixes #131600.
Restore the explicit comparison form for the number terminator check in
`Utf8JsonReader.TryGetNumber`. The pattern-matching form is semantically
equivalent, but introduced a large Linux ARM64 regression in
`System.Text.Json.Tests.Perf_Get.GetUInt64`.
## Performance
EgorBot on an Azure Ampere ARM64 machine measured the regressed pattern
form against the selectively restored reader code:
| State | Mean | Ratio |
|---|---:|---:|
| Pattern form (`43560bc7`) | 900.8 ns | 1.00 |
| Restored reader comparisons | 515.4 ns | 0.57 |
The cumulative bisection further narrowed the transition from 515.6 ns
at `fa936cfa` to approximately 896 ns after this condition changed. The
intervening commits only modify `Debug.Assert` expressions in Release
builds.
Results:
-
EgorBot/Benchmarks#508 (comment)
-
EgorBot/Benchmarks#509 (comment)
> [!NOTE]
> This pull request description was prepared with GitHub Copilot.
---------
Co-authored-by: Copilot <[email protected]>1 parent 6d0c10d commit 94157b0
3 files changed
Lines changed: 11 additions & 11 deletions
File tree
- src/libraries/System.Text.Json/src/System/Text/Json
- Reader
- Writer
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1174 | 1174 | | |
1175 | 1175 | | |
1176 | 1176 | | |
1177 | | - | |
| 1177 | + | |
1178 | 1178 | | |
1179 | 1179 | | |
1180 | 1180 | | |
| |||
1200 | 1200 | | |
1201 | 1201 | | |
1202 | 1202 | | |
1203 | | - | |
| 1203 | + | |
1204 | 1204 | | |
1205 | 1205 | | |
1206 | 1206 | | |
| |||
1341 | 1341 | | |
1342 | 1342 | | |
1343 | 1343 | | |
1344 | | - | |
| 1344 | + | |
1345 | 1345 | | |
1346 | 1346 | | |
1347 | 1347 | | |
| |||
1490 | 1490 | | |
1491 | 1491 | | |
1492 | 1492 | | |
1493 | | - | |
| 1493 | + | |
1494 | 1494 | | |
1495 | 1495 | | |
1496 | 1496 | | |
| |||
2264 | 2264 | | |
2265 | 2265 | | |
2266 | 2266 | | |
2267 | | - | |
| 2267 | + | |
2268 | 2268 | | |
2269 | 2269 | | |
2270 | 2270 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1505 | 1505 | | |
1506 | 1506 | | |
1507 | 1507 | | |
1508 | | - | |
| 1508 | + | |
1509 | 1509 | | |
1510 | 1510 | | |
1511 | 1511 | | |
| |||
1529 | 1529 | | |
1530 | 1530 | | |
1531 | 1531 | | |
1532 | | - | |
| 1532 | + | |
1533 | 1533 | | |
1534 | 1534 | | |
1535 | 1535 | | |
| |||
1624 | 1624 | | |
1625 | 1625 | | |
1626 | 1626 | | |
1627 | | - | |
| 1627 | + | |
1628 | 1628 | | |
1629 | 1629 | | |
1630 | 1630 | | |
| |||
1703 | 1703 | | |
1704 | 1704 | | |
1705 | 1705 | | |
1706 | | - | |
| 1706 | + | |
1707 | 1707 | | |
1708 | 1708 | | |
1709 | 1709 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
| 226 | + | |
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| |||
0 commit comments