Skip to content

Commit 599145d

Browse files
LoopedBard3Copilot
andauthored
[PERF] Retire default Mono performance runs and builds on main (#134602)
<!-- --> > [!IMPORTANT] > This is dependent on dotnet/performance#5322. Those shared controls must land before this change because the current runtime callers pass the new `runMono` parameter. ## Summary Retire default Mono performance runs and unnecessary performance builds from runtime main while preserving CoreCLR and NativeAOT workloads. - Disable Mono desktop and WASM runs in the current performance callers, including the public WASM PR sanity pipeline. - Remove the Mono-only slow nightly schedule while retaining private CoreCLR Linux and Windows ARM64 runs. - Default the five Mono build selectors to false. Keep registration and upload selections unchanged, and route WASM builds through the runtime-owned wrapper exactly once. - Make desktop and WASM build wrappers CoreCLR-only by default. Retain guarded manual Mono builders and source-only gapfill Mono opt-ins. - Preserve the CoreCLR WASM flavor forwarded by the existing platform/global-build adapter when preparing artifacts. Preserve `BrowserWasmCoreCLR` and host tool packs; publish workload-transfer artifacts only for an explicit manual Mono build. Older runtime branches are intentionally unchanged. The shared performance controls default to true for backward compatibility; only current runtime main callers opt out. General runtime product and CI Mono jobs, manual performance tools, and guarded builder implementations remain available. Related: #134397 and #134337. This change does not close either issue. ## Validation Based on runtime main `586bc324f6d3aa3c11aac1d1fde8a2eea072b91e`, pulled with `git pull --ff-only upstream main`. - Parsed all seven changed YAML files and ran `git diff --check`. - Checked 64 Mono/WASM build-selector combinations for registration/upload symmetry and unique WASM producers. - Checked 120 normal, PR, manual, scheduled, and project caller configurations, preserving non-Mono consumers. - Checked 32 gapfill source/cached/manual combinations, with extra Mono producers restricted to explicit source-build opt-ins. - Compared CoreCLR wrapper definitions and default/manual WASM payloads with the baseline, accounting for the conditional transfer change. The strengthened local check traces existing parameter forwarding, verifies effective CoreCLR flavor, and rejects duplicate post-build arguments. - Cross-checked the shared performance caller/producer/artifact contract with the companion change. - Checked boolean and string-valued Mono flags, including effective preparation scripts, `BrowserWasm` publication, and workload-transfer artifacts. Azure Pipelines service-side previews of public pipeline 156 and internal performance pipeline 702 exposed a duplicate `runtimeFlavor` parameter in the initial PR head: the global-build adapter already forwards this parameter, so repeating it in the nested helper arguments is invalid. The public preview of the runtime baseline with the performance PR source successfully expanded, confirming this was introduced by the initial patch. Corrective commit `7c40ead5642cf32385907884d2b3c16524ec0f42` removes only the redundant nested argument; the strengthened local check fails before the correction and passes afterward. The internal slow pipeline 1012 preview succeeded at the initial PR sources with `onlySanityCheck: true` and `runPrivateJobs: true`, producing the monitor, Linux/Windows ARM64 CoreCLR builds, and two corresponding sanity runs, with no Mono jobs. Subsequent public/internal performance previews compiled but exposed a second issue: the legacy mapping-style `runMono` value was tested for truthiness, admitting the nonempty string `false`. Commit `61d7faf36fa2204b1480e0061e49238ceca88daf` uses `eq(parameters.runMono, true)`; the local artifact/script check fails before this correction and passes afterward for both boolean and string inputs. ### End-to-end sanity test runs (2026-09-24) All three runs used both PR sources together, with resolved repository versions verified as runtime **`61d7faf36fa2204b1480e0061e49238ceca88daf`** (this PR) and performance **`3ac9d6f5c73175e677c7211d2ea44d0f8496c16b`** (dotnet/performance#5322). | Pipeline | Test run | Result | |---|---|---| | dotnet-runtime-perf | [3086818](https://dev.azure.com/dnceng/internal/_build/results?buildId=3086818) | Failed only on the pre-existing SVE sanity-filter issue; 46/47 Helix work items passed. | | dotnet-runtime-perf-slow | [3086817](https://dev.azure.com/dnceng/internal/_build/results?buildId=3086817) | Passed: Linux and Windows ARM64 CoreCLR builds and both Helix sanity work items. | | runtime-wasm-perf | [1611277](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1611277) | Passed: CoreCLR WASM build and both V8 benchmark jobs, including R2R. | Final-head service-side expansion succeeded for all three pipelines, with no Mono build/run jobs or Mono-only workload transfers. All benchmark commands used `--only-sanity`; the slow run also enabled `runPrivateJobs` so the CoreCLR ARM64 jobs actually executed. The internal runs used `parkerbibus/mono-runtime-retirement` and `parkerbibus/mono-pipeline-controls`; public WASM used the two GitHub PR head refs. The standard run's only failed work item, `arm64.sve.net11.0.Partition0`, built successfully but combined `--anyCategories SVE` with `--filter System.Tests.Perf_*`, excluding all SVE benchmark classes under `SveBenchmarks`. The later missing-artifact exception was secondary. This conflicting argument generation was reproduced from both the PR and unchanged [upstream-base harness source](https://github.com/dotnet/performance/blob/1f0e0f68889a0996f30e265846446549a801800e/scripts/run_performance_job.py#L516-L632), not by running a separate baseline pipeline. [Failure console](https://helix.dot.net/api/2019-06-17/jobs/1c31a264-58b7-40c0-a7a6-4eeef60eb586/workitems/arm64.sve.net11.0.Partition0/console). All other builds and work items passed; SVE validation remains outside this change and was not rerun. ## Known limitations and scope - Existing gapfill forwarding of undeclared desktop `viperMicroNoR2R` and `downloadSpecificBuild` parameters remains unchanged. Existing Mono AOT cached-artifact handling also remains unchanged. Full live gapfill validity is not claimed. - The unrelated CoreCLR R2R-interpreter x64 upload versus ARM64 producer mismatch remains untouched. - No release-branch changes, runtime-version selectors, live pipeline service changes, merges, or ready-for-review actions are included. > [!NOTE] > This description and the implementation were generated with GitHub Copilot. --------- Co-authored-by: Copilot App <[email protected]>
1 parent c0c1c33 commit 599145d

7 files changed

Lines changed: 58 additions & 65 deletions

File tree

‎eng/pipelines/performance/perf-build.yml‎

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,25 @@ parameters:
3131
type: boolean
3232
default: true
3333
- name: wasm
34-
displayName: Build WebAssembly (wasm)
34+
displayName: Build WebAssembly Mono (wasm)
3535
type: boolean
36-
default: true
36+
default: false
3737
- name: monoAot_arm64_linux
3838
displayName: Build Mono AOT Arm64 Linux
3939
type: boolean
40-
default: true
40+
default: false
4141
- name: monoAot_x64_linux
4242
displayName: Build Mono AOT x64 Linux
4343
type: boolean
44-
default: true
44+
default: false
4545
- name: mono_x64_linux
4646
displayName: Build Mono x64 Linux
4747
type: boolean
48-
default: true
48+
default: false
4949
- name: mono_arm64_linux
5050
displayName: Build Mono Arm64 Linux
5151
type: boolean
52-
default: true
52+
default: false
5353
- name: nativeAot_arm64_ios
5454
displayName: Build native AOT Arm64 iOS
5555
type: boolean
@@ -152,8 +152,6 @@ extends:
152152
- coreclr_x86_windows
153153
- ${{ if eq(parameters.coreclr_arm64_android, true) }}:
154154
- coreclr_arm64_android
155-
- ${{ if eq(parameters.wasm, true) }}:
156-
- wasm
157155
- ${{ if eq(parameters.monoAot_arm64_linux, true) }}:
158156
- monoAot_arm64_linux
159157
- ${{ if eq(parameters.monoAot_x64_linux, true) }}:
@@ -166,13 +164,17 @@ extends:
166164
- nativeAot_arm64_ios
167165
- ${{ if eq(parameters.coreclr_arm64_ios, true) }}:
168166
- coreclr_arm64_ios
169-
- ${{ if eq(parameters.wasm_coreclr, true) }}:
170-
- wasm_coreclr
171167
- ${{ if eq(parameters.coreclr_r2r_interpreter, true) }}:
172168
- coreclr_r2r_interpreter
173169
${{ if parameters.mauiFramework }}:
174170
mauiFramework: ${{ parameters.mauiFramework }}
175171

172+
# Select Mono locally without adding parameters to shared callers of older runtime wrappers.
173+
- ${{ if or(parameters.wasm, parameters.wasm_coreclr) }}:
174+
- template: /eng/pipelines/performance/templates/perf-wasm-build-jobs.yml
175+
parameters:
176+
runMono: ${{ parameters.wasm }}
177+
176178
- ${{ if and(ne(variables['System.TeamProject'], 'public'), or(eq(variables['Build.Reason'], 'IndividualCI'), parameters.runPrivateJobs)) }}:
177179
- stage: UploadArtifacts
178180
displayName: 'Upload Artifacts'

‎eng/pipelines/performance/perf-gapfill.yml‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ parameters:
3232

3333
- name: run_mono_micro
3434
type: boolean
35-
default: true
35+
default: false
3636

3737
- name: run_mono_interpreter
3838
type: boolean
39-
default: true
39+
default: false
4040

4141
- name: run_mono_aot
4242
type: boolean
43-
default: true
43+
default: false
4444

4545
- name: run_android_coreclr_jit
4646
type: boolean
@@ -79,6 +79,7 @@ extends:
7979
- ${{ if eq(parameters.run_wasm, true) }}:
8080
- template: /eng/pipelines/runtime-wasm-perf-jobs.yml@performance
8181
parameters:
82+
runMono: false
8283
${{ if eq(variables['System.TeamProject'], 'internal') }}:
8384
runProfile: 'v8'
8485
runtimeRepoAlias: self
@@ -90,6 +91,13 @@ extends:
9091
${{ if parameters.onlySanityCheck }}:
9192
onlySanityCheck: true
9293

94+
# Explicit Mono source runs need their own producers; the default runtime build is CoreCLR-only.
95+
- ${{ if and(eq(parameters.downloadSpecificBuildId, 0), or(parameters.run_mono_micro, parameters.run_mono_interpreter, parameters.run_mono_aot)) }}:
96+
- template: /eng/pipelines/performance/templates/perf-mono-build-jobs.yml
97+
parameters:
98+
mono_x64: ${{ or(parameters.run_mono_micro, parameters.run_mono_interpreter) }}
99+
monoAot_x64: ${{ parameters.run_mono_aot }}
100+
93101
# Runtime perf jobs (non-WASM) — included when any non-WASM group is enabled.
94102
# Per-job-group toggles are forwarded to runtime-perf-jobs.yml as parameter overrides.
95103
- ${{ if or(eq(parameters.run_viper_micro, true), eq(parameters.run_viper_micro_nor2r, true), eq(parameters.run_mono_micro, true), eq(parameters.run_mono_interpreter, true), eq(parameters.run_mono_aot, true), eq(parameters.run_android_coreclr_jit, true), eq(parameters.run_android_coreclr_r2r, true)) }}:

‎eng/pipelines/performance/perf-slow.yml‎

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ parameters:
22
- name: runPrivateJobs
33
type: boolean
44
default: false
5-
- name: runScheduledJobs
6-
type: boolean
7-
default: false
85
- name: onlySanityCheck
96
type: boolean
107
default: false
@@ -38,14 +35,6 @@ variables:
3835
- name: enableHelixJobMonitor
3936
value: true
4037

41-
schedules:
42-
- cron: "30 2 * * *"
43-
displayName: Every night at 2:30AM
44-
branches:
45-
include:
46-
- main
47-
always: true
48-
4938
extends:
5039
template: /eng/pipelines/common/templates/pipeline-with-resources.yml
5140
parameters:
@@ -65,8 +54,7 @@ extends:
6554
- ${{ if ne(variables['System.TeamProject'], 'public') }}:
6655
- template: /eng/pipelines/runtime-slow-perf-jobs.yml@performance
6756
parameters:
68-
${{ if or(in(variables['Build.Reason'], 'Schedule'), parameters.runScheduledJobs) }}:
69-
runScheduledJobs: true
57+
runMono: false
7058
${{ if or(notin(variables['Build.Reason'], 'Schedule', 'Manual'), parameters.runPrivateJobs) }}:
7159
runPrivateJobs: true
7260
runtimeRepoAlias: self

‎eng/pipelines/performance/perf.yml‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,6 @@ variables:
3232
- name: enableHelixJobMonitor
3333
value: true
3434

35-
#
36-
# For the 'schedule' case, only wasm/jsc perf jobs are run.
37-
# And the rest are build jobs - wasm, mono, coreclr, and libraries.
38-
#
39-
# Since, we are not running *any* perf jobs, none of these builds are needed,
40-
# thus the whole scheduled run can be disabled.
41-
#
4235
schedules:
4336
- cron: "0 0 * * 1"
4437
displayName: Weekly Monday 12am UTC Build
@@ -67,8 +60,7 @@ extends:
6760

6861
- template: /eng/pipelines/runtime-wasm-perf-jobs.yml@performance
6962
parameters:
70-
#${{ and(ne(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'Schedule')) }}:
71-
# runProfile: 'non-v8'
63+
runMono: false
7264
${{ if eq(variables['System.TeamProject'], 'internal') }}:
7365
runProfile: 'v8'
7466
runtimeRepoAlias: self
@@ -82,6 +74,12 @@ extends:
8274
parameters:
8375
runtimeRepoAlias: self
8476
performanceRepoAlias: performance
77+
monoMicro:
78+
enabled: false
79+
monoInterpreter:
80+
enabled: false
81+
monoAot:
82+
enabled: false
8583
jobParameters:
8684
${{ if parameters.onlySanityCheck }}:
8785
onlySanityCheck: true

‎eng/pipelines/performance/runtime-wasm-perf.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ extends:
3838
runtimeRepoAlias: self
3939
performanceRepoAlias: performance
4040
runProfile: 'v8'
41+
runMono: false
4142
jobParameters:
4243
onlySanityCheck: true
4344
#downloadSpecificBuild:

‎eng/pipelines/performance/templates/perf-build-jobs.yml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,4 @@ jobs:
1111
windows_x86: true
1212
android_arm64: true
1313
coreclr_r2r_interpreter: true
14-
osx_arm64: true
15-
16-
# build mono for AOT
17-
- template: /eng/pipelines/performance/templates/perf-mono-build-jobs.yml
18-
parameters:
19-
mono_x64: true
20-
monoAot_x64: true
14+
osx_arm64: true
Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,28 @@
1+
parameters:
2+
runMono: false
3+
14
jobs:
2-
# Build Mono runtime for browser-wasm (used by default wasm benchmarks)
3-
- template: /eng/pipelines/common/platform-matrix.yml
4-
parameters:
5-
jobTemplate: /eng/pipelines/common/global-build-job.yml
6-
buildConfig: Release
7-
runtimeFlavor: mono
8-
platforms:
9-
- browser_wasm
10-
jobParameters:
11-
buildArgs: -s mono+libs+host+packs -c $(_BuildConfig) /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
12-
nameSuffix: wasm
13-
isOfficialBuild: false
14-
# The wasm-tools workload manifest now includes the CoreCLR browser-wasm runtime pack, so the
15-
# workload install below needs the CoreCLR runtime and Crossgen2 packs staged into the local
16-
# feed. They're produced by the wasm_coreclr build job, so depend on it and download them.
17-
dependsOn:
18-
- build_browser_wasm_linux_Release_wasm_coreclr
19-
postBuildSteps:
20-
- template: /eng/pipelines/performance/templates/perf-wasm-prepare-artifacts-steps.yml
21-
parameters:
22-
configForBuild: Release
23-
downloadCoreClrWorkloadPackages: true
5+
# Build Mono only for explicitly selected performance builds.
6+
- ${{ if eq(parameters.runMono, true) }}:
7+
- template: /eng/pipelines/common/platform-matrix.yml
8+
parameters:
9+
jobTemplate: /eng/pipelines/common/global-build-job.yml
10+
buildConfig: Release
11+
runtimeFlavor: mono
12+
platforms:
13+
- browser_wasm
14+
jobParameters:
15+
buildArgs: -s mono+libs+host+packs -c $(_BuildConfig) /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
16+
nameSuffix: wasm
17+
isOfficialBuild: false
18+
# The wasm-tools workload manifest includes CoreCLR packs that the Mono build doesn't produce.
19+
dependsOn:
20+
- build_browser_wasm_linux_Release_wasm_coreclr
21+
postBuildSteps:
22+
- template: /eng/pipelines/performance/templates/perf-wasm-prepare-artifacts-steps.yml
23+
parameters:
24+
configForBuild: Release
25+
downloadCoreClrWorkloadPackages: true
2426

2527
# Build CoreCLR runtime for browser-wasm (used by --wasm-coreclr benchmarks)
2628
- template: /eng/pipelines/common/platform-matrix.yml
@@ -42,4 +44,4 @@ jobs:
4244
sdkDirName: dotnet-none
4345
includeRefPack: false
4446
includeCoreClrToolchainPacks: true
45-
publishCoreClrWorkloadPackages: true
47+
publishCoreClrWorkloadPackages: ${{ parameters.runMono }}

0 commit comments

Comments
 (0)