Repository navigation
Commit 2ffdb87
Address review feedback on the wasm corerun kit
Fix a stale breadcrumb in testkit.cmake that pointed at a file name the kit
never shipped under, and stop compiling the profiler test library on wasm.
The profiler tree is already CLRTestTargetUnsupported for browser, but its
native directory is picked up by the recursive globber in src/tests, so it
built 30+ sources that nothing can ever link. Guard it the same way the
sibling ijw directory guards itself, which drops the browser native test
build from 118 static archives to 117.
Also note why the '%24' and '%25' escapes in CLRTest.WasmCorerun.targets are
deliberate: '%24' keeps a property name literal in an error message instead
of expanding it, and '%25' is an escaped '%', so the response-file guard
already rejects any percent escape.
Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 19490400-17c9-47ef-9240-064c656904701 parent 78bcb23 commit 2ffdb87
3 files changed
Lines changed: 15 additions & 2 deletions
File tree
- src
- coreclr/hosts/corerun/wasm
- tests
- Common
- profiler/native
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
133 | 136 | | |
134 | 137 | | |
135 | 138 | | |
| |||
195 | 198 | | |
196 | 199 | | |
197 | 200 | | |
198 | | - | |
| 201 | + | |
| 202 | + | |
199 | 203 | | |
200 | 204 | | |
201 | 205 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
1 | 10 | | |
2 | 11 | | |
3 | 12 | | |
| |||
0 commit comments