Repository navigation
Commit 18f89a4
authored
Change VOLATILE_MEMORY_BARRIER for x64 Unix (#131807)
Currently the macro is defined as asm volatile ("" : : : "memory"). That
caused a recent regression in HndWriteBarrier due to an added
VolatileStore where clang adds an extra dummy jmp instruction to the
very next location after a call to HndWriteBarrierWorker. This happens
due to LLVM internal handling of the asm volatile ("" : : : "memory").
This change fixes it by replacing the barrier definition for x64 Unix by
__atomic_signal_fence(__ATOMIC_SEQ_CST)
This is a pure compiler only barrier and it doesn't introduce the side
effect like the asm volatile ("" : : : "memory").
Close #1306981 parent 23ec3d9 commit 18f89a4
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
0 commit comments