Fix race condition in CA1001 analyzer #6784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@CollinAlpert for review |
sharwell
suggested changes
Jul 20, 2023
There was a problem hiding this comment.
Recommend using TemporarySet<string> for this. There are several usage examples in the repo if you do a Find All References for TemporarySet<T>.Empty. This set eliminates all allocations and pooled object churn for the common case where the set remains empty.
Author
|
@sharwell Addressed feedback |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6784 +/- ##
==========================================
- Coverage 96.34% 96.34% -0.01%
==========================================
Files 1386 1386
Lines 326057 326204 +147
Branches 10721 10728 +7
==========================================
+ Hits 314141 314282 +141
- Misses 9210 9215 +5
- Partials 2706 2707 +1 |
sharwell
reviewed
Jul 21, 2023
sharwell
reviewed
Jul 21, 2023
sharwell
approved these changes
Jul 24, 2023
amiru3f
pushed a commit
to amiru3f/roslyn-analyzers
that referenced
this pull request
Jul 26, 2023
Fix race condition in CA1001 analyzer
amiru3f
pushed a commit
to amiru3f/roslyn-analyzers
that referenced
this pull request
Jul 26, 2023
Fix race condition in CA1001 analyzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6780