Use SourceTextValueProvider instead of ConditionalWeakTable for ApiData cache #6614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6614 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 1374 1374
Lines 320898 320911 +13
Branches 10390 10393 +3
=======================================
+ Hits 309362 309379 +17
+ Misses 9054 9051 -3
+ Partials 2482 2481 -1 |
| /// </summary> | ||
| private readonly ConditionalWeakTable<AdditionalText, ApiData> _additionalTextToApiData = new(); | ||
| private static readonly SourceTextValueProvider<ApiData> s_shippingApiDataProvider = new(static text => ReadApiData(text, isShippedApi: true)); | ||
| private static readonly SourceTextValueProvider<ApiData> s_nonShippingApiDataProvider = new(static text => ReadApiData(text, isShippedApi: false)); |
Member
There was a problem hiding this comment.
i'd honestly prefer we just have AdditionalTextValueProvider
Author
There was a problem hiding this comment.
IMO this is a solid move forward for the analyzer in the known absence of that API. Also note that this analyzer references Roslyn 1.2.1 for maximum compatibility with downstream projects, so even if AdditionalTextValueProvider was added, it would potentially be problematic to adopt in the short term.
mavasani
approved these changes
May 1, 2023
mavasani
left a comment
mavasani
left a comment
There was a problem hiding this comment.
LGTM. You'd want to follow-up with @CyrusNajmabadi to also get his confirmation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.