Fix RS1014 false positive discovered in roslyn #6442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
reviewed
Jan 18, 2023
src/Microsoft.CodeAnalysis.Analyzers/Core/ImmutableObjectMethodAnalyzer.cs
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6442 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 1365 1365
Lines 317494 317523 +29
Branches 10269 10269
=======================================
+ Hits 305265 305293 +28
+ Misses 9793 9792 -1
- Partials 2436 2438 +2 |
mavasani
approved these changes
Jan 18, 2023
|
@Youssef1313 Are there lot of false positives due to this regression? We just released version 3.3.4 of the analyzer NuGet package. |
Member
Author
|
@mavasani This is likely affecting dotnet/roslyn only. So external consumers should hopefully be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.