Fix the generator building twice#81950
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom Jan 9, 2026
Merged
Conversation
This explicit SetTargetFramework would have been necessary when IntegrationTests.csproj targeted a TFM which wouldn't support a netstandard2.0 reference. Since we're consuming this through a ProjectReference, MSBuild will try to validate that the consumed reference is compatible with our TFM, but by default won't realize that if we're actually outputting this as an Analyzer type it won't actually matter. This is causing overbuilding though and since this project now targets only netstandard2.0 compatible TFMs, we can just drop this. Fixes dotnet/dotnet#4121
JoeRobich
approved these changes
Jan 9, 2026
Member
|
/backport to release/dev18.3 |
Contributor
|
Started backporting to |
2 tasks
dibarbet
added a commit
that referenced
this pull request
Jan 12, 2026
Backport of #81950 to release/dev18.3 /cc @dibarbet @jasonmalinowski ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicit SetTargetFramework would have been necessary when IntegrationTests.csproj targeted a TFM which wouldn't support a netstandard2.0 reference. Since we're consuming this through a ProjectReference, MSBuild will try to validate that the consumed reference is compatible with our TFM, but by default won't realize that if we're actually outputting this as an Analyzer type it won't actually matter.
This is causing overbuilding though and since this project now targets only netstandard2.0 compatible TFMs, we can just drop this.
Fixes dotnet/dotnet#4121