Stop referencing the outdated NetAnalyzers package#81855
Stop referencing the outdated NetAnalyzers package#81855jjonescz merged 5 commits intodotnet:mainfrom
Conversation
|
|
||
| <!-- Disable SDK supplied netanalyzers as we reference them from nugets instead --> | ||
| <PropertyGroup> | ||
| <EnableNetAnalyzers>false</EnableNetAnalyzers> |
There was a problem hiding this comment.
I don't recall the defaults, but maybe for .NET Framework (maybe Standard as well?), this probably defaults to false. So better to explicitly set to true.
|
I'm concerned about this change. At any given time, there are at least 2 different SDKs that we are building with: the SDK from a vertical build in dotnet/dotnet, and the SDK installed locally. What if we start getting warnings in one that we can't address without getting warnings in the other? |
|
We don't build with warnings-as-errors in source build and in unified build, I presume for this exact reason (we can already get different warnings due to having different compiler and other analyzers from the sdk). That's also not a roslyn-specific issue, it can happen to any vmr repo. |
|
@333fred do you still have concerns here? |
4 participants
Pointed out by @Youssef1313 in #81805 (comment).
Inspecting binlog of this PR's CI build shows NetAnalyzers are still included, but from SDK.