Migrate certain formatting settings over to new options system#81503
Migrate certain formatting settings over to new options system#81503CyrusNajmabadi merged 16 commits intodotnet:mainfrom
Conversation
|
|
||
| public static readonly IReadOnlyDictionary<string, VisualStudioOptionStorage> Storages = new Dictionary<string, VisualStudioOptionStorage>() | ||
| { | ||
| // Modern settings-manager stored options. |
There was a problem hiding this comment.
Can we use this for all VS options, or are there still options that are not available from this API?
There was a problem hiding this comment.
Can we now remove
?There was a problem hiding this comment.
So, there are still some roaming options that do different things with vb vs C#. so i need to keep this.
There was a problem hiding this comment.
Can we use this for all VS options, or are there still options that are not available from this API?
I'm genuinely not sure. This option is a case where these were platform options that moved to a new location with a new key.
We still use RoamingProfileStorage to store a bunch of our options, and it's unclear to me if those are found though ISettingManager.
Given that these 4 are high profile options that are currently broken, i'd prefer to fix in isolation (esp. if we want to backport) and then worry about the rest later.
There was a problem hiding this comment.
Sure, let's fix these now. I was wondering if we can simplify in a follow up.
| @@ -311,18 +367,13 @@ public bool TryFetch(LocalUserRegistryOptionPersister persister, OptionKey2 opti | |||
| {"csharp_format_on_typing", new RoamingProfileStorage("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Typing")}, | |||
| {"dotnet_format_on_paste", new RoamingProfileStorage("TextEditor.%LANGUAGE%.Specific.FormatOnPaste")}, | |||
| #pragma warning disable CS0612 // Type or member is obsolete | |||
|
/backport to release/dev18.0 |
|
Started backporting to |
4 participants
Editor migrated these and dumped the data in the old locations.
Fixes #80877