Remove MSBuild dependencies from BuidlHost deps.json#80958
Remove MSBuild dependencies from BuidlHost deps.json#80958JoeRobich merged 2 commits intorelease/dev17.10from
Conversation
| --> | ||
| <_MsbuildVersion>17.3.4</_MsbuildVersion> | ||
| </PropertyGroup> | ||
| <ItemGroup Condition="'$(DotnetBuildFromSource)' == 'true'"> |
There was a problem hiding this comment.
Is there a reason we wouldn't just do the PackageDownloadAndReference for source build too? I guess maybe it's going to break source build because it doesn't know how to redirect it to the source built version?
There was a problem hiding this comment.
From a comment on the original PR:
I see what happened, in SBRP the net472 asset is missing: https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/microsoft.build.framework/17.3.4/ref
I learned that source build isn't really meant to have .NETFramework targets so that might not have been the root cause, but I bet there is something like that - where the SBRP packages differ from the real packages in a way that causes an error
There was a problem hiding this comment.
@jasonmalinowski Since we know this is working in main, I would prefer not to try anything new in the servicing PR.
2 participants
basically a backport of #75561