Skip to content

Fix XAML peek in VS editor. XamlPeekableItemFactory needs to implement exported interface.#80919

Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom
spadapet:dev/peterspa/XamlPeekableItemFactory
Oct 27, 2025
Merged

Fix XAML peek in VS editor. XamlPeekableItemFactory needs to implement exported interface.#80919
jasonmalinowski merged 1 commit intodotnet:mainfrom
spadapet:dev/peterspa/XamlPeekableItemFactory

Conversation

@spadapet
Copy link
Contributor

XamlPeekableItemFactory was meant to implement IXamlPeekableItemFactory for the XAML editor to use, but that interface was missed. Adding it fixes the XAML peek feature.

@spadapet spadapet requested a review from a team as a code owner October 27, 2025 20:57
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 27, 2025
@jasonmalinowski jasonmalinowski self-assigned this Oct 27, 2025
@jasonmalinowski jasonmalinowski merged commit c308bfa into dotnet:main Oct 27, 2025
26 checks passed
@jasonmalinowski
Copy link
Member

/backport to release/dev18.0

@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 27, 2025
@github-actions
Copy link
Contributor

Started backporting to release/dev18.0 (link to workflow run)

phil-allen-msft added a commit that referenced this pull request Oct 30, 2025
… needs to implement exported interface. (#80923)

Backport of #80919 to release/dev18.0

/cc @jasonmalinowski @spadapet

## Customer Impact

## Regression

- [ ] Yes
- [ ] No

[If yes, specify when the regression was introduced. Provide the PR or
commit if known.]

## Testing

[How was the fix verified? How was the issue missed previously? What
tests were added?]

## Risk

[High/Medium/Low. Justify the indication by mentioning how risks were
measured and addressed.]
@davidwengier davidwengier modified the milestones: Next, 18.3 Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants