Fix issue when caching CompilationWithAnalyzers against ProjectState instead of a project#80422
Conversation
…instead of a Project
|
@jasonmalinowski ptal. Will also do a test insertion. |
|
Note: i do not expect this to cause perf issues. We already do checksum checking at a higher layer (LSP) to not bother computing diagnostics for things that aren't impacted by user changes. In other words the LSP caching layer knows to return quickly, unless something has actually changed int he input ot a project (in which case its checksum changes). What this does though is ensure that N things asking questions about hte same solution on the OOP side (like diags, code actions, or fix all) operate on the same instance. And then that all just cleanly gets dumped as the solution moves forward. |
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Oh wow that cache never made sense before. Definitely wrong with source generators now, but even then references to other compilations could still get out of sync...
|
Looks like all the speedometer stuff is ngen, which is being addressed by the revert of the sig help change. So merging this in. |
|
/backport to release/dev18.0 |
|
Started backporting to |
…inst ProjectState instead of a project (#80922) Backport of #80422 to release/dev18.0 /cc @jasonmalinowski @CyrusNajmabadi ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
3 participants
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2576607
Pipeline: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12443017&view=results
Build: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/672951