Fix syntax map for unmodified partial constructor#80417
Merged
tmat merged 1 commit intodotnet:mainfrom Sep 24, 2025
Merged
Conversation
Member
Author
|
@DustinCampbell ptal |
tmat
commented
Sep 23, 2025
| using var _1 = PooledHashSet<ISymbol>.GetInstance(out var addedSymbolsBuilder); | ||
| using var _2 = ArrayBuilder<(ISymbol? oldSymbol, ISymbol? newSymbol)>.GetInstance(edits.Count, out var resolvedSymbols); | ||
|
|
||
| foreach (var edit in edits) |
Member
Author
There was a problem hiding this comment.
Extracted to ResolveSymbols
tmat
commented
Sep 23, 2025
|
|
||
| return otherNode; | ||
|
|
||
| static int GetChildIndex(SyntaxNode parent, SyntaxNode node) |
Member
Author
There was a problem hiding this comment.
This could be implemented more efficiently in the compiler, or if the SyntaxNode exposed SlotIndex API.
Member
Author
|
/backport to release/dev18.0 |
Contributor
|
Started backporting to release/dev18.0: https://github.com/dotnet/roslyn/actions/runs/18015541080 |
2 tasks
phil-allen-msft
added a commit
that referenced
this pull request
Sep 30, 2025
…constructor (#80462) Backport of #80417 to release/dev18.0 /cc @tmat ## Customer Impact ## Regression - [ ] Yes - [x] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
This was referenced Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79320