Conversation
a5936de to
3c74204
Compare
3c74204 to
10670d8
Compare
| ${{ else }}: | ||
| value: OSX.13.Amd64 | ||
|
|
||
| parameters: |
There was a problem hiding this comment.
Why did you use paramaters here and not just add onto variables? Usually I think of parameters in a top level YML as items we pass during manually queueing. This pipeline isn't manually queued that I'm aware of though.
There was a problem hiding this comment.
I don't believe you can have object types variables - using parameters allows me to just pass around a single pool parameter, instead of having different sets of variables to set different fields in the pool (like we had to do before).
All variables are strings and are mutable.
|
@jaredpar anything else on this? |
| jobs: | ||
| - job: ${{ parameters.jobName }} | ||
| pool: | ||
| ${{ if ne(parameters.queueName, '') }}: |
There was a problem hiding this comment.
this is the part where using a single pool parameter is much nicer. Don't need conditional definitions here and 3 separate arguments.
| ${{ else }}: | ||
| value: OSX.13.Amd64 | ||
|
|
||
| parameters: |
Consolidates our pool definitions so its easier to change which pool we're using.
Also switches us to the .net eng managed pools (which have higher parallelism and currently can provide machines faster).