Collection literals: address comments #68793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
cston
commented
Jun 27, 2023
| } | ||
|
|
||
| var implicitReceiver = new BoundObjectOrCollectionValuePlaceholder(syntax, isNewInstance: true, targetType) { WasCompilerGenerated = true }; | ||
| // PROTOTYPE: When generating a List<T>, should we use the well-known |
cston
commented
Jun 27, 2023
| var result = element switch | ||
| { | ||
| BoundBadExpression => element, | ||
| // PROTOTYPE: Should spread elements support target type? |
cston
commented
Jun 27, 2023
| } | ||
| } | ||
| """; | ||
| // PROTOTYPE: Should compile and run successfully: expectedOutput: "[1, 2, 3], " |
Contributor
Author
cston
commented
Jun 27, 2023
| CompileAndVerify(new[] { source, s_collectionExtensions }, expectedOutput: "(System.Int32[]) [1, 2, 3], "); | ||
| } | ||
|
|
||
| // PROTOTYPE: Test other variance cases. |
Contributor
Author
cston
commented
Jun 27, 2023
| } | ||
| } | ||
| """; | ||
| // PROTOTYPE: Confirm we should generate ListBase<int> instances for both x and y. |
Contributor
Author
cston
commented
Jun 27, 2023
| [ConditionalTheory(typeof(CoreClrOnly))] | ||
| [CombinatorialData] | ||
| public void SpreadElement_01( | ||
| [CombinatorialValues("IEnumerable", "IEnumerable<int>", "int[]", "List<int>", "Span<int>", "ReadOnlySpan<int>")] string spreadType, |
Contributor
Author
cston
commented
Jun 27, 2023
| } | ||
| """; | ||
| var comp = CreateCompilation(source); | ||
| // PROTOTYPE: Should spread elements support target type? (Should we infer IEnumerable<int>?) |
cston
commented
Jun 27, 2023
| } | ||
| } | ||
| """; | ||
| // PROTOTYPE: Should spread elements support target type? (Should we infer IEnumerable<string>?) |
cston
commented
Jun 27, 2023
| } | ||
|
|
||
| [ConditionalFact(typeof(CoreClrOnly), AlwaysSkip = "PROTOTYPE: 'IAsyncEnumerable<int>' does not contain a definition for 'GetAwaiter'")] | ||
| public void Async_03() |
Contributor
Author
There was a problem hiding this comment.
Added open issue to test plan #66418: support IAsyncEnumerable<T> for spread element?
…nto collections-comments
333fred
reviewed
Jun 28, 2023
| { | ||
| // PROTOTYPE: This is not a great diagnostic. Users could easily run into this and be confused. Can we do | ||
| // better. For example: | ||
| // This is not a great diagnostic. Users could easily run into this and be confused. Can we do |
Contributor
Author
There was a problem hiding this comment.
This particular case involves a dictionary element which is not currently supported. I've logged an issue to improve the diagnostic for the previous example (A)[1]: #68862.
RikkiGibson
reviewed
Jun 28, 2023
| return GetValEscape(switchExpr.SwitchArms.SelectAsArray(a => a.Value), scopeOfTheContainingExpression); | ||
|
|
||
| case BoundKind.CollectionLiteralExpression: | ||
| // PROTOTYPE: Revisit if spans may be optimized to avoid heap allocation. |
RikkiGibson
approved these changes
Jun 28, 2023
…nto collections-comments
…nto collections-comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address PROTOTYPE comments.