Skip to content

Conversation

@CyrusNajmabadi
Copy link
Member

No description provided.

CyrusNajmabadi and others added 18 commits January 27, 2023 11:46
Add support for generating ref-members in SyntaxGenerator
Avoid unnecessary parsing in brace-completion
Revert "Prefer list-pattern for length-only counterexamples (dotnet#66541)"
…6552)

* Introduce helper

* Use helper

* In progress

* In progress

* In progress

* In progress

* In progress

* In progress

* In progress

* Move skip methods to where they are used

* Move skip methods to where they are used

* Move skip methods to where they are used

* Move skip methods to where they are used

* Move skip methods to where they are used

* move

* Restore error messages

* Restore exact behavior

* Restore exact behavior

* Use discards

* Use for argument parsing

* Move object/collection initializer parsing to new helper

* Use helper for attributes

* Make lambdas non-capturing

* Move type parameter parsing to new helper

* Simplify

* Remove special cases

* move pattern parsing to helpers

* move pattern parsing to helpers

* add test

* Update tests

* Make code more uniform

* Consistency

* Use helper for with parsing

* Use helper for with parsing

* Simplify error recovery

* Improve test code

* Match specific assignments

* Allow trailing comma

* Remove unnecessary lambda

* Remove unnecessary lambda

* Simplify

* Simplify

* Simplify

* Reorder

* Fix formatting

* Simplify completion code

* Add docs

* Use helper for enum parsing

* Remove

* Make all arguments required

* Remove comment

* Remove comment

* Move
@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners January 28, 2023 21:34
@ghost ghost added the Area-Compilers label Jan 28, 2023
@CyrusNajmabadi CyrusNajmabadi changed the base branch from main to features/CollectionLiterals January 28, 2023 21:35
@CyrusNajmabadi CyrusNajmabadi requested a review from a team January 28, 2023 21:35
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner January 28, 2023 21:35
@CyrusNajmabadi
Copy link
Member Author

@333fred @jcouv . thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit ffa3a66 into dotnet:features/CollectionLiterals Jan 29, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the mainToCollections branch January 29, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.