Allow missing CommandLineArgsForDesignTimeEvaluation msbuild property#66367
Merged
tmat merged 3 commits intodotnet:mainfrom Jan 19, 2023
Merged
Conversation
ghost
added
the
Member
Author
|
@jasonmalinowski @jmarolf PTAL |
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Impl/ProjectSystem/CPS/CPSProjectFactory.cs
Outdated
Show resolved
Hide resolved
5 tasks
Member
Author
|
@jasonmalinowski ping |
sharwell
reviewed
Jan 19, 2023
| project.StartBatch(); | ||
|
|
||
| if (commandLineArgs != null) | ||
| if (!string.IsNullOrEmpty(commandLineArgs)) |
Contributor
There was a problem hiding this comment.
💡 If you use RoslynString, you can omit the subsequent !
sharwell
approved these changes
Jan 19, 2023
Member
|
@tmat will this make 17.5? |
Contributor
|
@drewnoakes This is currently in a 17.6 branch. It would need to be backported to make a 17.5 release. |
Member
|
Given the regression is in 17.5, that is worth considering. |
Member
|
It appears we did forget to backport this to 17.5. We're starting that conversation internally now. |
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Feb 22, 2023
…dotnet#66367) * Allow missing CommandLineArgsForDesignTimeEvaluation msbuild property * Feedback * Unused using
arunchndr
pushed a commit
that referenced
this pull request
Feb 22, 2023
…ignTimeEvaluation17.5 Port to 17.5: Allow missing CommandLineArgsForDesignTimeEvaluation msbuild property (#66367)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property was introduced in 17.4 by 6238d10
If compiler targets are loaded from SDK without this property set we fail to load the project.
Fixes regression introduced in 17.5 that caused projects that did not have this property set to fail to load.