Hot Reload: Fix reloadable type regression#63106
Merged
JoeRobich merged 2 commits intodotnet:release/dev17.3from Aug 1, 2022
Merged
Hot Reload: Fix reloadable type regression#63106JoeRobich merged 2 commits intodotnet:release/dev17.3from
JoeRobich merged 2 commits intodotnet:release/dev17.3from
Conversation
ghost
added
the
Member
Author
|
@davidwengier PTAL |
davidwengier
approved these changes
Jul 31, 2022
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Whoops! thanks for fixing :)
|
@tmat is this going into 17.3? Which version specifically? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression #63103 introduced by #61806
Constructors of the synthesized type
C.<>c, which is a nested synthesized type in a reloadable typeCwere updated instead of added.VS Feedback: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1580286
Ask mode bug: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1581287