Skip to content

Run test on both x64 and x86#52538

Merged
jaredpar merged 1 commit intodotnet:mainfrom
Youssef1313:patch-4
Apr 12, 2021
Merged

Run test on both x64 and x86#52538
jaredpar merged 1 commit intodotnet:mainfrom
Youssef1313:patch-4

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 10, 2021

Closes #462 (The other disabled tests are tracked by #28639)
Closes #327 (please confirm this issue doesn't need any further actions).

@Youssef1313 Youssef1313 requested a review from a team as a code owner April 10, 2021 08:07
@ghost ghost added the Area-Compilers label Apr 10, 2021
@Youssef1313
Copy link
Member Author

Re-triggering build. The failure is an unrelated network issue:

The operation has timed out.
System.Net.WebException: The operation has timed out.
   at System.Net.ConnectStream.Read(Byte[] buffer, Int32 offset, Int32 size)
   at Microsoft.PowerShell.Commands.StreamHelper.WriteToStream(Stream input, Stream output, PSCmdlet cmdlet)
   at Microsoft.PowerShell.Commands.StreamHelper.SaveStreamToFile(Stream stream, String filePath, PSCmdlet cmdlet)
   at Microsoft.PowerShell.Commands.InvokeWebRequestCommand.ProcessResponse(WebResponse response)
   at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()
at Ensure-ProcDump, D:\a\1\s\eng\build.ps1: line 580
at TestUsingRunTests, D:\a\1\s\eng\build.ps1: line 429
at <ScriptBlock>, D:\a\1\s\eng\build.ps1: line 711
at <ScriptBlock>, D:\a\_temp\e6ad85b9-298e-434e-84d9-6476ef3fcda8.ps1: line 3
at <ScriptBlock>, <No file>: line 1

@Youssef1313 Youssef1313 reopened this Apr 10, 2021
@RikkiGibson
Copy link
Member

Closes #462

Confused by this bit. It seems like solving this issue would involve also removing the x86 class from the tests. Did I miss something?

@Youssef1313
Copy link
Member Author

@RikkiGibson There are other disabled tests that are tracked by #28639, so can't remove the x86 class in this PR.

@RikkiGibson RikkiGibson added Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI labels Apr 12, 2021
@jaredpar jaredpar merged commit 0b7631d into dotnet:main Apr 12, 2021
@ghost ghost added this to the Next milestone Apr 12, 2021
@Youssef1313 Youssef1313 deleted the patch-4 branch April 13, 2021 05:30
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ConditionalFact(typeof(x86)) RoundtripSerializeDeepExpression test stack overflows.

4 participants