Skip to content

Move enforcement of "no static type as type argument" to constraint validation#513

Merged
gafter merged 5 commits intodotnet:masterfrom
gafter:fix345
Feb 18, 2015
Merged

Move enforcement of "no static type as type argument" to constraint validation#513
gafter merged 5 commits intodotnet:masterfrom
gafter:fix345

Conversation

@gafter
Copy link
Member

@gafter gafter commented Feb 14, 2015

Fixes #345 and #511

@gafter gafter added Area-Compilers 4 - In Review A fix for the issue is submitted for review. Language-C# Bug labels Feb 14, 2015
@gafter gafter self-assigned this Feb 14, 2015
@gafter gafter added this to the 1.0-rc2 milestone Feb 14, 2015
@gafter
Copy link
Member Author

gafter commented Feb 14, 2015

To: @AlekseyTs @agocke @VSadov @VladimirReshetnikov @jaredpar

Can a couple of you please take a look?

@jaredpar
Copy link
Member

👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missing the test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Fact]?

@gafter
Copy link
Member Author

gafter commented Feb 17, 2015

To: @AlekseyTs @agocke @VSadov @VladimirReshetnikov

Thank you @jaredpar. Can I please have one more "Heck Yeah"?

@gafter
Copy link
Member Author

gafter commented Feb 18, 2015

To: @AlekseyTs @agocke @VSadov @VladimirReshetnikov

Can I please have one more "Heck Yeah"?

@jaredpar
Copy link
Member

image

;)

@AlekseyTs
Copy link
Contributor

LGTM

gafter added a commit that referenced this pull request Feb 18, 2015
Move enforcement of "no static type as type argument" to constraint validation
@gafter gafter merged commit 976cf1b into dotnet:master Feb 18, 2015
@gafter gafter deleted the fix345 branch February 18, 2015 18:49
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roslyn fails to diagnose static type as type argument, reports "Failed to emit module".

4 participants