Merged
Conversation
Member
Author
Member
Author
There was a problem hiding this comment.
No idea what happened here. Will revert this.
Member
|
You'll also need the updated reference to Microsoft.CodeAnalysis.Resources.Properietary. I can cherry-pick it out and commit it separately, or you can add the commit to this pull. |
Member
Author
|
@agocke I was just about to test this on a non-dev machine and see if that was still the case. Can you point me to the SHA1 that I need to cherry pick? |
BuildAndTest.proj
Outdated
Member
There was a problem hiding this comment.
Duplicate of previous line.
Member
|
As long as bugs are filed tracking the 64-bit disables, 👍 |
Member
This change allows provides the option of running our tests in 64 bit mode. Simply invoke BuildAndTest.proj in the following manner: > msbuild /v:m /m BuildAndTest.proj /p:Test64=true There are a set of tests today that don't run correctly in 64. All have been annotated with the trait > Require32=true We need to push on these to get a clean 64 bit run. But short term this will at least give us protection against regressions.
There were some issues getting xunit to respect the -notrait option hence we decided to simplify and use ConditionalFact
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows provides the option of running our tests in 64 bit
mode. Simply invoke BuildAndTest.proj in the following manner:
There are a set of tests today that don't run correctly in 64. All have
been annotated with the trait
We need to push on these to get a clean 64 bit run. But short term this
will at least give us protection against regressions.