Customizable Obsolete diagnostics#42518

Merged

RikkiGibson merged 21 commits intodotnet:masterfrom

RikkiGibson:obsoleteattribute

Mar 30, 2020

Member

RikkiGibson commented Mar 17, 2020

Closes #42119

This is still a WIP, but I would appreciate some review on the general approach in use. Several things still need testing, including diagnostics on usage of symbols from metadata.


          WIP for customizable obsolete diagnostics

883128f

RikkiGibson added the Area-Compilers label

RikkiGibson requested a review from a team as a code owner

March 17, 2020 23:46

RikkiGibson added the PR For Personal Review Only label

This comment has been minimized.

Sign in to view

RikkiGibson added 2 commits

March 18, 2020 12:36


          Add custom tag for custom Obsolete diagnostic

1eb6df7


          Test some more source scenarios

RikkiGibson removed the PR For Personal Review Only label

jcouv added PR For Personal Review Only and removed PR For Personal Review Only labels


          Read some obsolete properties from metadata

0872c6e

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/MetadataReader/PEModule.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/Symbols/Attributes/CommonAttributeData.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/Symbols/Attributes/CommonAttributeData.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/Symbols/Attributes/ObsoleteAttributeData.cs

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/MetadataReader/PEModule.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/MetadataReader/PEModule.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/MetadataReader/PEModule.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/MetadataReader/PEModule.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/MetadataReader/PEModule.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Errors/CustomObsoleteDiagnosticInfo.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Errors/CustomObsoleteDiagnosticInfo.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Errors/CustomObsoleteDiagnosticInfo.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Errors/CustomObsoleteDiagnosticInfo.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Errors/CustomObsoleteDiagnosticInfo.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Errors/CustomObsoleteDiagnosticInfo.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Errors/CustomObsoleteDiagnosticInfo.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Symbols/ObsoleteAttributeHelpers.cs Outdated

Contributor

AlekseyTs commented Mar 19, 2020 •

edited

Loading

I would expect some changes on VB side as well. #Closed

Contributor

AlekseyTs commented Mar 19, 2020 •

edited

Loading

Done with review pass (iteration 4) #Closed

Member Author

RikkiGibson commented Mar 27, 2020

@terrajobst Yes

AlekseyTs reviewed

View reviewed changes

src/Compilers/Core/Portable/Symbols/Attributes/CommonAttributeData.cs

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Emitter/Model/AttributeDataAdapter.cs Outdated

RikkiGibson added 2 commits

March 27, 2020 11:25


          Remove unnecessary assert

54cdd2e


          Address feedback

8bc4393

AlekseyTs reviewed

View reviewed changes

src/Compilers/VisualBasic/Test/Emit/Attributes/AttributeTests_ObsoleteAttribute.vb


          Fix doc comment

1fdb590

Contributor

AlekseyTs commented Mar 27, 2020 •

edited

Loading

Done with review pass (iteration 15) #Closed

Contributor

AlekseyTs commented Mar 27, 2020 •

edited

Loading

Done with review pass (iteration 18) #Closed

jaredpar reviewed

View reviewed changes

src/Compilers/Core/Portable/Diagnostic/CustomObsoleteDiagnosticInfo.cs Outdated

src/Compilers/Core/Portable/MetadataReader/MetadataDecoder.cs Outdated

src/Compilers/Core/Portable/MetadataReader/MetadataDecoder.cs

src/Compilers/Core/Portable/MetadataReader/PEModule.cs

src/Compilers/Core/Portable/Symbols/Attributes/CommonAttributeData.cs Outdated

RikkiGibson added 2 commits

March 27, 2020 16:47


          Add VB tests

ef23621


          Address some feedback

c7836dd

RikkiGibson requested a review from a team

March 30, 2020 19:50

Member Author

RikkiGibson commented Mar 30, 2020

@dotnet/roslyn-compiler Please review

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Test/Emit/Attributes/AttributeTests_WellKnownAttributes.cs Outdated

AlekseyTs reviewed

View reviewed changes

src/Compilers/VisualBasic/Test/Emit/Attributes/AttributeTests_ObsoleteAttribute.vb Outdated

AlekseyTs approved these changes

View reviewed changes

Contributor

AlekseyTs left a comment

LGTM (iteration 20)

jaredpar approved these changes

View reviewed changes


          Make test constants private

b7a9893

RikkiGibson merged commit 34fdb69 into dotnet:master

ghost added this to the Next milestone

RikkiGibson deleted the obsoleteattribute branch

March 30, 2020 23:14

sharwell modified the milestones: Next, temp, 16.6.P3

Joe4evr mentioned this pull request

[Meta] List of APIs considered for "Better Obsoletion" dotnet/runtime#33360

Closed

jeffhandley mentioned this pull request

[release/5.0-preview8] Mark Obsoletions in .NET 5 (#39269 and #39607) dotnet/runtime#39661

Closed

RikkiGibson mentioned this pull request

[master] Update dependencies from dotnet/efcore dotnet/runtime dotnet/aspnetcore#25399

Merged

eerhardt mentioned this pull request

Obsoletions with a DiagnosticId still get warnings in generated code dotnet/runtime#101738

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels