Fix issues in MetadataAsSource XML documentation comment conversion#41119
Merged
sharwell merged 2 commits intodotnet:masterfrom Jan 31, 2020
Merged
Fix issues in MetadataAsSource XML documentation comment conversion#41119sharwell merged 2 commits intodotnet:masterfrom
sharwell merged 2 commits intodotnet:masterfrom
Conversation
…rmed" XML comments contain superfluous /// markers for every line-break in the original comment.
Contributor
|
Wow, adding a test for this is way more difficult than I expected. I am hoping to get a baseline test completed shortly as part of #24188, and once that is merged we can update this pull request to show how it improves the situation. |
jinujoseph
added
Area-IDE
Community
Contributor
|
📝 I'm doing a manual validation for this so it can be merged sooner. |
Contributor
Author
|
If there's anything I can help you with to get this done faster, please tell me. |
Contributor
|
Yeah this is a big improvement 👍 |
sharwell
approved these changes
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #39877
See #39877 (comment) for a detailed description.
TL;DR
DocCommentConverter.ConvertDocCommentToRegularCommentreturns anything.///).