added a space to experience e2e getting sources, making change, and subm...#4
Conversation
…ubmitting pull request
added a space to experience e2e getting sources, making change, and subm...
There was a problem hiding this comment.
I thought we preferred one space after periods now? We may need to publish a documentation style guide... :)
There was a problem hiding this comment.
Yeah, one space after period is clearly superior.
There was a problem hiding this comment.
Is one space the standard we use in docs? If so then we should undo this.
There was a problem hiding this comment.
I don't think we had a standard. @dpoeschl might have been referring to the widely held opinion that double spaces are a holdover from the typewriter days.
There was a problem hiding this comment.
If the file is authored in VI, you should use one space after a period. Otherwise two spaces are permissible. This clearly proves that VI is the superior editor. ;-)
There was a problem hiding this comment.
👌
Two spaces after a period is fine in markdown. It improves readability in the raw markdown but will still be rendered as a single space by browsers after being converted to HTML.
Miguel's Markdown Style Guide.
There was a problem hiding this comment.
BUT I LOOK AT THE SOURCE IN VI AND TWO SPACES ARE WRONG.
Pro tip: If you're losing an argument, use all caps. This helps convincing people.
There was a problem hiding this comment.
I think you've oversold the "pro" in "pro tip"
Oooo! Burn!
Also, you're all jerks. Is this what you're like when there's not enough code to review? Go fix some bugs! 😃 😃 😃
|
Ok, wow, after sending mail to Jared that he could ignore or delete this, and making a painfully clear title, I'm a bit surprised to see our dollars wasted debating this :-). On a serious note, yes, it is a misconception that two spaces after punctuation is silly and out of date. It is a misconception because of what Dustin cites which is true in almost all editors, as well as the fact that some editors have special commands for sentences and paragraphs that leverage this typography. Also, rendering engines that consistently handle whitespace that follows punctuation creates output with lower usability due to eye tracking and visual parsing. Anyway, to say it again, I was simply debugging e2e work flow and tried to pick the most unobservable change I could ... FAIL :-) |
|
Well, if we're stating disclaimers, I should mention that I just wanted an excuse to try out the Pull Request commenting system. 😃 |
|
Nice!! :-) I want a like button on your comment :-) And we're doing a good job of setting a comfortable tone so that customers don't have to feel all nervous about saying silly stuff here :-) |
|
👍 |
* Call this.DeclaringCompilation.EnsureReadOnlyAttributeExists() when needed * Promote EmbeddedAttribute to be used by both compilers * Generate Embedded attributes on PE Module Builder * Thread PEModuleBuilder through Symbol.AddSynthesizedAttributes() * Fix failing tests * Base case passing * Refactor ReadOnlyAttribute to IsReadOnlyAttribute * Fix build break * More Tests * Clean up * PR Comments #1 PR Comments #3 PR Comments #4 PR Comments #5 PR Comments #6 PR Comments # 7 * Handle NoPIA Added more tests * Lambdas and Local functions no longer generate attributes in symbols Added tests for constructors and operators Signal need for synthesized attributes in local rewriter for lambdas an local functions Clean up * Clean up * More PR Feedback * Adding more tests * More PR Comments * More tests for explicit interface implementations * Latest PR Comments * Moved EnsureIsReadOnlyAttributeExists to AfterAddingTypeMembersChecks * Fix failing tests
Add ExternalAccess.Razor shims for newly added DocumentPropertiesService APIs.
…ayer Simplify migration from EditorFeatures to Features
Add script for proper expansion
8 participants
...itting pull request