Don't preselect enums on backspace#368
Merged
rchande merged 1 commit intodotnet:masterfrom Feb 10, 2015
Merged
Conversation
Member
|
👍 |
Contributor
There was a problem hiding this comment.
WorkItem(###)? Do we have a convention for tagging tests with github workitem numbers that distinguishes from TFS workitem numbers?
Contributor
There was a problem hiding this comment.
Maybe [WorkItem(287, "https://github.com/dotnet/roslyn/issues/287")]? What do you think @Pilchie? I like having a direct link from source (can click in the editor).
Member
There was a problem hiding this comment.
Yes, I was going to propose that too. In the long term, maybe we make another overload that doesn't require the int param.
rchande
force-pushed
the
FixBackspacePreselection
branch
2 times, most recently
from
7ff0972 to
ce65a47
Compare
When backspacing in VB, we used to prefer preselected items over text matches. Dev12 does this for object creation preseletion, but not enum preselection. We should match that behavior. Fixes dotnet#287.
rchande
force-pushed
the
FixBackspacePreselection
branch
from
ce65a47 to
2471450
Compare
Contributor
|
👍 |
rchande
added a commit
that referenced
this pull request
Feb 10, 2015
Don't preselect enums on backspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When backspacing in VB, we used to prefer preselected items over text
matches. Dev12 does this for object creation preseletion, but not enum
preselection. We should match that behavior.
Fixes #287.