Closed
Conversation
- TryGetChar - TryPeekChar - TryPeakCharAt
Renamed a local 2Here" to "offset"
Closed
Member
|
@AdamSpeight2008 This pull request failed the automatic merge and build and test. Please merge the latest sources and try again. |
gafter
added
the
Resolution-Won't Fix
dibarbet
pushed a commit
to dibarbet/roslyn
that referenced
this pull request
Nov 21, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a common pattern to have
CanGetChar()to be closely followed by a call toPeekCharGetCharPeekAheadCharSo I think could be beneficial to have Try variants of them.
This will allow us to "cache" the character and avoid subsequent additional calls to those methods.
It also allows to inline some If Statements into their enclosing While condition.