add unit test for Temporary Storage preserving SourceText Encoding#354
Merged
heejaechang merged 1 commit intodotnet:masterfrom Feb 10, 2015
Merged
add unit test for Temporary Storage preserving SourceText Encoding#354heejaechang merged 1 commit intodotnet:masterfrom
heejaechang merged 1 commit intodotnet:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
This (TestTemporaryStorage) doesn't appear to test the encoding, which was the whole point of adding this test, wasn't it?
Contributor
Author
There was a problem hiding this comment.
oh.. I changed TestTemporaryStorage method. probably missed adding it.
Contributor
Author
There was a problem hiding this comment.
I added necessary change but it looks like while I am doing it I did something wrong and ends up pushed to roslyn master directly...
dibarbet
pushed a commit
to dibarbet/roslyn
that referenced
this pull request
Nov 21, 2025
Pipeline optimizations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added an unit test