Create new projects for System.Runtime.Analyzers#338
Create new projects for System.Runtime.Analyzers#338srivatsn merged 4 commits intodotnet:masterfrom srivatsn:splitfxcop
Conversation
Move rule CA1001 to this project. Rewrite the codefixer for it to be based on DocumentEditor and hence language agnostic. Fix for CA1001 shouldn't generate a dispose method if there is already one in the type. Instead modify that method to make it the interface implementation. Adding some tests.
There was a problem hiding this comment.
I think @Pilchie might have said something in another review about newlines at the end of proj files, but I can't remember why they mattered.
There was a problem hiding this comment.
Ah yes. Fixed them.
There was a problem hiding this comment.
It's not the end of the world, but many Unix utils don't like files that don't end in a line ending.
Kevin Pilch-Bisson
http://twitter.com/Pilchie
From: Srivatsn Narayanan [email protected]
Sent: Monday, February 9, 2015 6:08:46 PM
To: dotnet/roslyn
Cc: Kevin Pilch-Bisson
Subject: Re: [roslyn] Create new projects for System.Runtime.Analyzers (#338)
In src/Diagnostics/FxCop/CSharp/CSharpFxCopRulesDiagnosticAnalyzers.csprojhttps://github.com//pull/338#discussion_r24384180:
@@ -107,4 +106,4 @@
-
+
Ah yes. Fixed them.
Reply to this email directly or view it on GitHubhttps://github.com//pull/338/files#r24384180.
…ysisanalyzers but since the codeanalysisanalyzers werent part of the solution VS didnt know. Once I merged the change that added them to the solution, VS got confused. Fixing the guids. Also adding newlines to the end.
There was a problem hiding this comment.
Do we need to check with anyone before we start adding namespaces under System?
There was a problem hiding this comment.
Not that I know of.
|
👍 |
…a new project was added.
There was a problem hiding this comment.
Is CodeFixProviderBase used anywhere in this project?
There was a problem hiding this comment.
No I've deleted this on my machine. That'll be part of the next change.
|
👍 |
Create new projects for System.Runtime.Analyzers
…ers. CSharpLang issue dotnet#338.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
6 participants
This is the start of work to split up the FxCop analyzers into multiple packages that can ship with the APIs that they address.
Move rule CA1001 to this project. Rewrite the codefixer for it to be based on DocumentEditor and hence language agnostic.
Fix for CA1001 shouldn't generate a dispose method if there is already one in the type. Instead modify that method to make it the interface implementation. Adding some tests.