Allow 'is' for static classes for compatibility#331
Merged
gafter merged 1 commit intodotnet:masterfrom Feb 10, 2015
Merged
Conversation
Member
Author
|
Hey, can a couple of you please look at this @jaredpar @AlekseyTs @VladimirReshetnikov @VSadov @agocke |
Contributor
There was a problem hiding this comment.
Should this comment be adjusted too?
Member
Author
|
Ping for review, please @jaredpar @AlekseyTs @VladimirReshetnikov @VSadov @agocke |
Contributor
|
Is the change in Roslyn.sln intentional? Otherwise LGTM. |
Member
|
LGTM |
but continue to report the diagnostic if "strict" mode is requested. Fixes dotnet#324
Member
Author
|
Reverting the change to Roslyn.sln, and squashing the commits. |
gafter
added a commit
that referenced
this pull request
Feb 10, 2015
Allow 'is' for static classes for compatibility. Fixes #324.
dibarbet
pushed a commit
to dibarbet/roslyn
that referenced
this pull request
Nov 21, 2025
Take care to use proper slashes per OS for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
but continue to report the diagnostic if "strict" mode is requested.
Fixes #324