Delete our copy of IsBuiltInRuleSet#330
Merged
tmeschter merged 1 commit intodotnet:masterfrom Feb 9, 2015
Merged
Conversation
This change deletes code we use to determine if a rule set file is one that shipped with VS, and thus cannot be modified or deleted. It was largely copied from code in Microsoft.VisualStudio.CodeAnalysis.Sdk.UI.dll, and we should just use the original instead.
Contributor
|
👍 |
Contributor
Author
|
@shyamnamboodiripad, @heejaechang, @jmarolf, @mavasani, could one of you take a look at this as well? |
Contributor
|
👍 |
tmeschter
added a commit
that referenced
this pull request
Feb 9, 2015
Delete our copy of IsBuiltInRuleSet
dibarbet
pushed a commit
to dibarbet/roslyn
that referenced
this pull request
Nov 21, 2025
Fix test logs collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change deletes code we use to determine if a rule set file is one
that shipped with VS, and thus cannot be modified or deleted. It was
largely copied from code in
Microsoft.VisualStudio.CodeAnalysis.Sdk.UI.dll, and we should just use
the original instead.